Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve relationship creation tool #53

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Conversation

martin-fleck-at
Copy link
Collaborator

  • Adapt edge creation tool to desired behavior: click tool, drag from element
  • Only perform selection when select tool is active (default)
  • Select edge after it has been created

relationship-tool

- Adapt edge creation tool to desired behavior
- Only perform selection when select tool is active (default)
- Select edge after it has been created
Copy link

github-actions bot commented Mar 18, 2024

Unit Test Results

  3 files  ±0   30 suites  ±0   2m 40s ⏱️ +11s
 71 tests ±0   71 ✅ ±0  0 💤 ±0  0 ❌ ±0 
216 runs  ±0  216 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2c658af. ± Comparison against base commit 7514d76.

♻️ This comment has been updated with latest results.

@harmen-xb
Copy link
Contributor

@martin-fleck-at I see you made a new PR. Screenshots look good. Is it ready to be reviewed?

@martin-fleck-at
Copy link
Collaborator Author

@harmen-xb Yes, please have a look. I waited for the CI to finish and then simply forgot to assign you.

Copy link
Contributor

@harmen-xb harmen-xb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me.

I made some small changes in the example files to make it a bit more readable.

@harmen-xb harmen-xb merged commit d6e9ef8 into main Mar 19, 2024
5 checks passed
@harmen-xb harmen-xb deleted the feature/relationshiptool branch March 19, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants