Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure form client's update listener is disposed properly #43

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Ensure form client's update listener is disposed properly #43

merged 1 commit into from
Nov 29, 2023

Conversation

martin-fleck-at
Copy link
Collaborator

Fixes #36

@github-actions GitHub Actions
Copy link

Unit Test Results

    3 files  ±0    30 suites  ±0   2m 26s ⏱️ +2s
  68 tests ±0    68 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
207 runs  ±0  207 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0bd13d9. ± Comparison against base commit 3481ce5.

harmen-xb
harmen-xb approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@harmen-xb harmen-xb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one :).

@harmen-xb harmen-xb merged commit 4fdee98 into main Nov 29, 2023
5 checks passed
@harmen-xb harmen-xb deleted the feature/issue-36 branch November 29, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harmen-xb harmen-xb harmen-xb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERROR Error: Cannot update an unmounted root.
2 participants
@martin-fleck-at @harmen-xb