Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace name/name_val with id/name in grammar for better semantics #42

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Replace name/name_val with id/name in grammar for better semantics #42

merged 2 commits into from
Nov 30, 2023

Conversation

martin-fleck-at
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2023 •
edited
Loading

Unit Test Results

    3 files  ±0    30 suites  ±0   2m 22s ⏱️ -2s
  68 tests ±0    68 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
207 runs  ±0  207 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8c38379. ± Comparison against base commit 3481ce5.

♻️ This comment has been updated with latest results.

harmen-xb
harmen-xb reviewed Nov 29, 2023
View reviewed changes
Copy link
Contributor

@harmen-xb harmen-xb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Martin,

Thanks for the changes, majority looks very good.

I had some questions/remarks in the comments.

extensions/crossmodel-lang/src/language-server/cross-model-naming.ts Outdated Show resolved Hide resolved
extensions/crossmodel-lang/src/language-server/cross-model-scope.ts Outdated Show resolved Hide resolved
extensions/crossmodel-lang/src/language-server/cross-model-scope.ts Outdated Show resolved Hide resolved
extensions/crossmodel-lang/src/language-server/cross-model-scope.ts Outdated Show resolved Hide resolved
extensions/crossmodel-lang/src/language-server/cross-model-validator.ts Show resolved Hide resolved
extensions/crossmodel-lang/src/language-server/generated/ast.ts Show resolved Hide resolved
@martin-fleck-at
Incorporate PR review
8c38379 
- Use 'id' consistently instead of 'name' even for descriptions
- Ignore generated files with prettier
- Ensure we give warning if ID field is missing
harmen-xb
harmen-xb approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@harmen-xb harmen-xb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good now :), thanks!

@martin-fleck-at martin-fleck-at merged commit 76c7430 into main Nov 30, 2023
5 checks passed
@martin-fleck-at martin-fleck-at deleted the feature/name_val_fix branch November 30, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sailingKieler sailingKieler sailingKieler left review comments

@harmen-xb harmen-xb harmen-xb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martin-fleck-at @sailingKieler @harmen-xb