Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve developer experience with consistent formatting #41

Merged
merged 8 commits into from
Nov 27, 2023

Conversation

martin-fleck-at
Copy link
Collaborator

  • Add format command for consistency with lint

  • Add spell checker recommendation

  • Specify consistent tab width of 3 spaces

  • Fix typos and markdown formatting issues

  • Apply consistent format on all files and organize imports
    -- Organize all imports by search&replace the same string in all files
    -- Run 'format' on repository

- Add format command for consistency with lint
- Add spell checker recommendation
- Specify consistent tab width of 3 spaces
- Organize all imports by search&replace the same string in all files
- Run 'format' on repository
Copy link

github-actions bot commented Nov 26, 2023

Unit Test Results

    3 files  ±0    30 suites  ±0   2m 21s ⏱️ -6s
  68 tests ±0    68 ✔️ ±0  0 💤 ±0  0 ±0 
207 runs  ±0  207 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit ad9ee17. ± Comparison against base commit 9afb1c3.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
CrossModel language Diagram Diagram with nodes and edges Simple file for diagram and edges, but descirption and name coming last ‑ CrossModel language Diagram Diagram with nodes and edges Simple file for diagram and edges, but descirption and name coming last
CrossModel language Diagram Diagram with nodes and edges Simple file for diagram and edges, but description and name coming last ‑ CrossModel language Diagram Diagram with nodes and edges Simple file for diagram and edges, but description and name coming last

♻️ This comment has been updated with latest results.

Copy link
Contributor

@harmen-xb harmen-xb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the changes, most at the config files. I only noticed one thing where Chevrotain and Chevrotrain are used. Should be the first one I think.

.vscode/settings.json Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@harmen-xb harmen-xb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@martin-fleck-at martin-fleck-at merged commit 3481ce5 into main Nov 27, 2023
5 checks passed
@martin-fleck-at martin-fleck-at deleted the feature/dev-experience branch November 27, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants