-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Langium 2.1.3 #40
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Langium > 2.0.0 only supports ESM so we refactor the extension to ESM Setup Changes - Set type to 'module' in package.json and update configs accordingly - Use esbuild to develop in ESM but compile to CJS for VSX Code Changes - Adapt all relative imports to use '.js' extension (even for '.ts') - Remove now obsolete adaptations of workspace manager Test Changes - Provide custom Jest configuration for ES modules - Use 'jest.useFakeTimers()' as specified in Jest documentation for ESM - Add '--experimental-vm-modules' Node flag to ESM test executions - Add 'NODE_NO_WARNINGS' environment variable to ignore ESM warning - Use unique report file names as we need to run twice (CJS, ESM) - Add display name to all test configs for nicer output - Adapt launch configs to properly debug single test or all tests
Closed
harmen-xb
reviewed
Nov 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all looks good to me, just some small questions in comments.
extensions/crossmodel-lang/src/glsp-server/handler/add-entity-operation-handler.ts
Show resolved
Hide resolved
extensions/crossmodel-lang/test/language-server/lexer/cross-model-lexer.test.ts
Outdated
Show resolved
Hide resolved
harmen-xb
reviewed
Nov 24, 2023
harmen-xb
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Langium > 2.0.0 only supports ESM so we refactor the extension to ESM
Setup Changes
Code Changes
Test Changes