Ensure form client's update listener is disposed properly

Fixes #36
CrossBreezeNL · Nov 29, 2023 · 0bd13d9 · 0bd13d9
1 parent 3481ce5
commit 0bd13d9
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/packages/form-client/src/browser/form-editor-widget.tsx b/packages/form-client/src/browser/form-editor-widget.tsx
@@ -56,11 +56,13 @@ export class FormEditorWidget extends ReactWidget implements NavigatableWidget,
       this.getResourceUri = this.getResourceUri.bind(this);
       this.loadModel();
 
-      this.formClient.onUpdate(event => {
-         if (event.sourceClientId !== FORM_CLIENT_ID && event.uri === this.getResourceUri().toString()) {
-            this.modelUpdated(event.model);
-         }
-      });
+      this.toDispose.push(
+         this.formClient.onUpdate(event => {
+            if (event.sourceClientId !== FORM_CLIENT_ID && event.uri === this.getResourceUri().toString()) {
+               this.modelUpdated(event.model);
+            }
+         })
+      );
    }
 
    protected async loadModel(): Promise<void> {