FRbinViewer - single video for multi line bin file fix #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, several days ago we have question on groups about short video for fireball ( FRbinViewer shortens video )
Last night I also got same bin file with 2 meteors for one fits file and see that for this case we generate only part of generated frames because for ffmpeg need correct sequence of image files but we have gaps in case multi lines.
It works with option : '-s', '--split' but it generates several video files
Proposed fix : use sequence numbering instead real frame number in bin file.
Also I improved timestamp option ("-t", "--timestamp") - it shows real time for meteors on video.
Example of result attached. Source bin file for testing could be get from groups link above or I could provide my if need (not sure if I can attach 40mb here)
FR_UA0005_20241010_013844_591_1059840_line_00.mp4