Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions to config file #352

Merged

Conversation

g7gpr
Copy link
Contributor

@g7gpr g7gpr commented Aug 15, 2024

These support quota management by disc use and deleting captured directories by count.

@Cybis320
Copy link
Contributor

We should try to keep to a 80-character line limit. The comments are exceeding that a little.

@Cybis320
Copy link
Contributor

This line break keeps it under 80:

; disabling quota management generates the reports, lists the files that would
; be deleted but prevents any action from being taken
; true = disabled, false = enabled

quota_management_disabled: true

; any one of the next three parameters missing or commented out disables the
; quota management each of the parameters is in GB.

@g7gpr g7gpr closed this Aug 19, 2024
@g7gpr g7gpr deleted the feature/disc_quotas_config branch August 19, 2024 00:14
@Cybis320
Copy link
Contributor

@g7gpr, What is the status on this? I see that the quota management was merged into ConfigReader and DeleteOldObservation but not the associated config options. Should we reopen this PR? See issue #387

@g7gpr g7gpr restored the feature/disc_quotas_config branch August 27, 2024 05:59
@g7gpr
Copy link
Contributor Author

g7gpr commented Aug 27, 2024

Yes, we should reopen. I deleted my branch as I thought this had been merged.

@g7gpr g7gpr reopened this Aug 27, 2024
@dvida dvida merged commit 1489cbe into CroatianMeteorNetwork:prerelease Sep 1, 2024
@g7gpr g7gpr deleted the feature/disc_quotas_config branch September 7, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants