Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all references to LSF #780

Merged
merged 7 commits into from
Dec 10, 2024
Merged

Conversation

al-rigazzi
Copy link
Collaborator

@al-rigazzi al-rigazzi commented Dec 10, 2024

Remove all references to LSF and LSB components, including JsrunSettings, BsubBatchSettings, and so on.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.62%. Comparing base (d7d979e) to head (22741a4).
Report is 17 commits behind head on develop.

Files with missing lines Patch % Lines
smartsim/database/orchestrator.py 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #780      +/-   ##
===========================================
- Coverage    83.91%   81.62%   -2.29%     
===========================================
  Files           83       84       +1     
  Lines         6284     7009     +725     
===========================================
+ Hits          5273     5721     +448     
- Misses        1011     1288     +277     
Files with missing lines Coverage Δ
smartsim/_core/control/controller.py 83.04% <ø> (-2.20%) ⬇️
smartsim/_core/launcher/__init__.py 100.00% <ø> (ø)
smartsim/_core/launcher/step/__init__.py 100.00% <ø> (ø)
smartsim/_core/launcher/stepInfo.py 68.33% <ø> (-31.67%) ⬇️
smartsim/_core/utils/telemetry/telemetry.py 88.37% <ø> (+0.72%) ⬆️
smartsim/entity/dbnode.py 90.67% <100.00%> (-0.56%) ⬇️
smartsim/experiment.py 85.77% <ø> (-0.10%) ⬇️
smartsim/settings/__init__.py 100.00% <ø> (ø)
smartsim/settings/settings.py 77.27% <ø> (-8.94%) ⬇️
smartsim/wlm/__init__.py 32.65% <ø> (-15.84%) ⬇️
... and 1 more

... and 37 files with indirect coverage changes

@al-rigazzi al-rigazzi merged commit f509ad6 into CrayLabs:develop Dec 10, 2024
24 checks passed
@al-rigazzi al-rigazzi deleted the drop-lsf branch December 10, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant