Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release action to remove CI Build Wheel #728

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

MattToast
Copy link
Member

Removes the use of CI Build Wheel now that SmartSim is a pure python package.

@MattToast MattToast added area: CI/CD Issues related to continuous integration and deployment area: release Issues related to release actions and procedures labels Sep 27, 2024
@MattToast MattToast requested a review from ashao September 27, 2024 00:23
@MattToast MattToast self-assigned this Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.80%. Comparing base (d7d979e) to head (b01c9fb).
Report is 11 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #728      +/-   ##
===========================================
- Coverage    83.91%   81.80%   -2.11%     
===========================================
  Files           83       84       +1     
  Lines         6284     7075     +791     
===========================================
+ Hits          5273     5788     +515     
- Misses        1011     1287     +276     

see 47 files with indirect coverage changes

Copy link
Collaborator

@ashao ashao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking this down. One suggestion to simplify even further, but we can always test this later

.github/workflows/release.yml Show resolved Hide resolved
@MattToast MattToast merged commit 0bab07c into CrayLabs:develop Sep 27, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: CI/CD Issues related to continuous integration and deployment area: release Issues related to release actions and procedures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants