Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken contribution link #129

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Fix broken contribution link #129

merged 1 commit into from
Mar 8, 2024

Conversation

nadamoukaddem
Copy link
Contributor

solves #127.

@nadamoukaddem nadamoukaddem self-assigned this Mar 8, 2024
@nadamoukaddem nadamoukaddem added the bug Something isn't working label Mar 8, 2024
@nadamoukaddem nadamoukaddem linked an issue Mar 8, 2024 that may be closed by this pull request
Link to Contribution markdown file incorrect in API Doc #127
Closed
@jeipollack
Copy link
Contributor

Fix is good.
Just note branch name does not follow the branch naming convention defined in our workflow:

bug/issue-<issue_number>/short-description

In this case the correct name would be:

bug/issue-127/fix_broken_link

or

bug/issue-127/docs_broken_link

@jeipollack jeipollack merged commit 51717bf into develop Mar 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeipollack jeipollack Awaiting requested review from jeipollack

Assignees

@nadamoukaddem nadamoukaddem

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link to Contribution markdown file incorrect in API Doc
2 participants
@nadamoukaddem @jeipollack