Memory Progress #609
Closed
Memory Progress #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `MockEnv` to use `types.Uint64` for time representation. - Introduced helper functions for memory operations: `readMemory` and `writeMemory`. - Replaced direct memory read/write calls in `hostGet` and other functions with the new helpers. - Removed the `MemoryAllocator` struct and related functions, simplifying memory management. - Cleaned up unused code and deleted obsolete files in the `libwasmvm` directory. - Adjusted function signatures and error handling for better clarity and consistency. This commit enhances the overall structure and readability of the codebase while ensuring proper memory handling.
run tests
…ve memory management error handling - Added `combined_code.txt` to .gitignore to prevent tracking of combined code files. - Improved debug output in `hostAbort` and `callContractFn` methods for better traceability during contract execution. - Enhanced memory management in `wazeroruntime.go` by adding error checks for deallocation calls and validating memory region sizes, ensuring safer memory operations. - Updated logging to provide clearer insights into memory reads and writes, including detailed error messages for better debugging.
- Introduced a new `parseParams` function to streamline the extraction and validation of common parameters across multiple contract methods. - Updated `Instantiate`, `Execute`, `Migrate`, `MigrateWithInfo`, `Sudo`, `Reply`, `Query`, `IBCChannelOpen`, `IBCChannelConnect`, `IBCChannelClose`, `IBCPacketReceive`, `IBCPacketAck`, `IBCPacketTimeout`, `IBCSourceCallback`, and `IBCDestinationCallback` methods to utilize the new parameter parsing logic, enhancing code maintainability and reducing redundancy. - Improved error handling for missing or invalid parameters, ensuring more robust contract function calls.
… debug logging - Refactored the `callContractFn` method in `wazeroruntime.go` to improve memory management by implementing region-based approaches for writing environment, message, and info data. - Added detailed debug logging to track memory operations and function calls, enhancing traceability during contract execution. - Introduced helper functions for memory allocation and reading, ensuring safer and more efficient memory handling. - Improved error handling for memory operations, validating regions and ensuring robust contract function calls. - Updated comments throughout the method to clarify the purpose of each section, improving code readability and maintainability.
…-cosmwasm into faddat/memory-progress
This reverts commit 8de7fad.
|
Closing because it is merged into #582 |
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another attempt at replacing wasmer with wazero. It is close, and contracts do respond to stuff from time to time.
But there seem to be memory issues, which we really need to get cleaned up.
I am merging this to #582, since it gets testfloats working