Failed changes for later reference #601
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
faddat
commented
Jan 6, 2025
faddat
commented
- most tests pass
- sleep`
- cleanup
- don't close cache in ReleasCache
- additional cleanup
- resolve further issues
- fix issues with siguantures
- memory management
- fix analyzecode
- database functions
- fix issues related to db_scan
- fix addr_validate
- add 3 types of sig verification
- add query_chain host function
- gci
- fix testfloats
- fix out of bounds memory access
- add missing host functions
- revert golangci changes to focus on the insantiate issue
- Refactor memory management and host functions in wasmvm
- testifylint execpt for the MockInfoBin
- Create tests.yml
- testifylint execpt for the MockInfoBin
- gci'd
- continue test cleanup
- gci is much better than goimports
- use latest linter
- resolve issues with goroutine
- enable errcheck and thelper linters
- remove manual host side deallocation
- progress...
- update runtime
- update contracts used in testing`
- update capabilities
- correct typo from adjusting tests.
- Revert "update capabilities"
- Revert "update runtime"
- add cryptographic imports
- replace deprecated library
- all signature mismatches resolved
- add validation.go
- TestStoreCode passes, introduce table-driven test
- improve debug
- lint
- update linter config
- Update .gitignore, modify mock time format, and enhance host function parameter handling
- restore libwasmvm to ease reference
- high quality debug info
- add additional debug (look at adapted vs actual...)
- turn on debug
- Enhance testing capabilities, improve gas tracking, and validate memory regions
- Add new contracts and update existing ones with improved schemas and configurations
- Refactor WazeroRuntime to support additional parameters in contract function calls
- Add gas tracking functionality and refactor gas costs in runtime
- Refactor tests and improve error handling in IBC and memory database
- Update .gitignore, enhance debug logging in host functions, and improve memory management error handling
- align runtime with lib
- Refactor WazeroRuntime to centralize parameter validation
- Enhance callContractFn with structured memory management and detailed debug logging
- fix lints
- Enhance memory management and debugging in WazeroRuntime
- Updated `MockEnv` to use `types.Uint64` for time representation. - Introduced helper functions for memory operations: `readMemory` and `writeMemory`. - Replaced direct memory read/write calls in `hostGet` and other functions with the new helpers. - Removed the `MemoryAllocator` struct and related functions, simplifying memory management. - Cleaned up unused code and deleted obsolete files in the `libwasmvm` directory. - Adjusted function signatures and error handling for better clarity and consistency. This commit enhances the overall structure and readability of the codebase while ensuring proper memory handling.
run tests
This reverts commit 3286d4f.
This reverts commit 80e9ddd.
… parameter handling
…ry regions - Expanded TESTING_CAPABILITIES in `lib_libwasmvm_test.go` to include additional CosmWasm versions. - Updated time format in `mocks.go` for better precision. - Refactored gas tracking in `hostfunctions.go` to use consistent variable naming and added checks for gas consumption across various operations. - Introduced validation for memory regions in `wazeroruntime.go` to ensure safe memory access and prevent out-of-bounds errors. - Added optional transaction hash field in `TransactionInfo` struct in `env.go` for enhanced transaction tracking.
…configurations - Introduced new contracts: burner, crypto-verify, cyberpunk, empty, floaty, hackatom, ibc-callbacks, ibc-reflect, ibc-reflect-send, nested-contracts, queue, reflect, and staking. - Each contract includes updated README files, Cargo.toml, and Cargo.lock for dependency management. - Enhanced schema files for better integration and functionality. - Added integration tests for various contracts to ensure reliability and performance. - Updated .cargo/config.toml files to standardize schema execution commands across contracts. - Improved overall project structure and documentation for better developer experience.
…unction calls - Updated multiple contract function calls in `wazeroruntime.go` to accept `otherParams` as a variadic argument, enhancing flexibility for future extensions. - Adjusted the `callContractFn` method to handle the new parameter structure, ensuring compatibility with existing functionality. - Improved overall code maintainability by standardizing function signatures across contract methods.
- Introduced a new file `gas.go` to define gas costs for various operations, including memory, database, and iterator operations. - Implemented `GasConfig` and `GasState` types to manage gas usage and limits during execution. - Refactored gas cost constants in `hostfunctions.go` to remove redundant definitions, centralizing gas cost management in `gas.go`. - Enhanced gas consumption tracking with methods to consume gas and check limits, improving overall gas management in the runtime environment.
- Added helper function to mark test functions in `ibc_test.go` for better test reporting. - Replaced `require.Equal` with `require.Empty` and `require.Len` for clearer assertions in IBC tests. - Simplified key and value checks in `memdb_iterator.go` by removing redundant nil checks. - Updated function signatures in `hostcrypto.go` and `hostfunctions.go` to use underscore for unused parameters, enhancing code clarity.
…ve memory management error handling - Added `combined_code.txt` to .gitignore to prevent tracking of combined code files. - Improved debug output in `hostAbort` and `callContractFn` methods for better traceability during contract execution. - Enhanced memory management in `wazeroruntime.go` by adding error checks for deallocation calls and validating memory region sizes, ensuring safer memory operations. - Updated logging to provide clearer insights into memory reads and writes, including detailed error messages for better debugging.
- Introduced a new `parseParams` function to streamline the extraction and validation of common parameters across multiple contract methods. - Updated `Instantiate`, `Execute`, `Migrate`, `MigrateWithInfo`, `Sudo`, `Reply`, `Query`, `IBCChannelOpen`, `IBCChannelConnect`, `IBCChannelClose`, `IBCPacketReceive`, `IBCPacketAck`, `IBCPacketTimeout`, `IBCSourceCallback`, and `IBCDestinationCallback` methods to utilize the new parameter parsing logic, enhancing code maintainability and reducing redundancy. - Improved error handling for missing or invalid parameters, ensuring more robust contract function calls.
… debug logging - Refactored the `callContractFn` method in `wazeroruntime.go` to improve memory management by implementing region-based approaches for writing environment, message, and info data. - Added detailed debug logging to track memory operations and function calls, enhancing traceability during contract execution. - Introduced helper functions for memory allocation and reading, ensuring safer and more efficient memory handling. - Improved error handling for memory operations, validating regions and ensuring robust contract function calls. - Updated comments throughout the method to clarify the purpose of each section, improving code readability and maintainability.
- Introduced new helper functions for memory allocation and reading in `wazeroruntime.go`, improving safety and efficiency. - Added a maximum memory pages constant to centralize memory configuration. - Refactored `callContractFn` to streamline memory operations and enhance debug logging for better traceability during contract execution. - Implemented region-based approaches for writing environment, message, and info data, ensuring robust memory handling. - Improved error handling and validation for memory operations, enhancing overall reliability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.