Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tests.yml #586

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Create tests.yml #586

wants to merge 4 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Dec 22, 2024

This PR uses standard github actions to run the wasmvm tests.

run tests
@faddat faddat mentioned this pull request Dec 23, 2024
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work for PRs that involve changes to libwasmvm because it would run the tests without building the new libwasmvm. You can check the CircleCI config. There we have a build job for the shared library that gets cached within the workflow.

@faddat
Copy link
Contributor Author

faddat commented Jan 9, 2025

What if I just move everything out of circleci?

@chipshort
Copy link
Collaborator

That would be an option, but seems like a lot of work for no real benefit.

@faddat
Copy link
Contributor Author

faddat commented Jan 11, 2025

the benefit is honestly enormous, and the work isn't huge, let me do it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants