Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor IteratorReference #501

Merged
merged 7 commits into from
Feb 23, 2024
Merged

Refactor IteratorReference #501

merged 7 commits into from
Feb 23, 2024

Conversation

webmaster128
Copy link
Member

I tried looking into #322 but the codebase was too confusing to me.

I hope this helps improve readbility and clarity about what is going on.

Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes

internal/api/iterator.go Outdated Show resolved Hide resolved
internal/api/iterator.go Outdated Show resolved Hide resolved
internal/api/iterator.go Outdated Show resolved Hide resolved
internal/api/iterator.go Show resolved Hide resolved
internal/api/iterator.go Outdated Show resolved Hide resolved
libwasmvm/src/iterator.rs Show resolved Hide resolved
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@webmaster128 webmaster128 merged commit 27656e4 into main Feb 23, 2024
13 checks passed
@webmaster128 webmaster128 deleted the iteratorRef branch February 23, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants