Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to wasmvm 2.2.0-rc.1 #2009

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update to wasmvm 2.2.0-rc.1 #2009

wants to merge 1 commit into from

Conversation

chipshort
Copy link
Collaborator

Gas changes are because of the patch releases that happened in between 2.1.2 and 2.2.0, not because of 2.2 itself.

@faddat
Copy link
Contributor

faddat commented Oct 21, 2024

I get the same error when building wasmd for v2.1.3

if I repetitively run tests with v2.1.2 I get

ok      github.com/CosmWasm/wasmd/x/wasm/ioutils        0.102s
runtime: bad pointer in frame github.com/CosmWasm/wasmvm/v2/internal/api.AnalyzeCode at 0xc0011474e0: 0x1
fatal error: invalid pointer found on stack

runtime stack:
runtime.throw({0x2c2d66a?, 0x44e0ba0?})
        /usr/local/go/src/runtime/panic.go:1067 +0x48 fp=0x7abdc1f709a8 sp=0x7abdc1f70978 pc=0x479888
runtime.adjustpointers(0x7abdc1f70ad0?, 0x7abdc1f70a68, 0x464be5?, {0x7abdc1f70ad0?, 0x423a300?})
        /usr/local/go/src/runtime/stack.go:640 +0x1ad fp=0x7abdc1f70a08 sp=0x7abdc1f709a8 pc=0x45afcd
runtime.adjustframe(0x7abdc1f70ad0, 0x7abdc1f70b30)
        /usr/local/go/src/runtime/stack.go:697 +0xd1 fp=0x7abdc1f70a98 sp=0x7abdc1f70a08 pc=0x45b0f1
runtime.copystack(0xc000d168c0, 0x0?)
        /usr/local/go/src/runtime/stack.go:945 +0x2e5 fp=0x7abdc1f70b90 sp=0x7abdc1f70a98 pc=0x45b805
runtime.shrinkstack(0xc000d168c0)
        /usr/local/go/src/runtime/stack.go:1247 +0x165 fp=0x7abdc1f70bb0 sp=0x7abdc1f70b90 pc=0x45c765
runtime.newstack()
        /usr/local/go/src/runtime/stack.go:1076 +0x39b fp=0x7abdc1f70cf0 sp=0x7abdc1f70bb0 pc=0x45bcfb
runtime.morestack()
        /usr/local/go/src/runtime/asm_amd64.s:621 +0x7a fp=0x7abdc1f70cf8 sp=0x7abdc1f70cf0 pc=0x48033a

goroutine 2353 gp=0xc000d168c0 m=4 mp=0xc000055c08 [running]:
strings.genSplit({0xc0018de540, 0x26}, {0x31d0cd0, 0x1}, 0x0, 0xffffffffffffffff?)
        /usr/local/go/src/strings/strings.go:236 +0x231 fp=0xc0011473d0 sp=0xc0011473c8 pc=0x5278b1
strings.Split(...)
        /usr/local/go/src/strings/strings.go:306
github.com/CosmWasm/wasmvm/v2/internal/api.AnalyzeCode({0x7abdbc17e420?, {0xc001064420?}}, {0xc001aa8c60?, 0x0?, 0x11ab627340?})
        /go/pkg/mod/github.com/!cosm!wasm/wasmvm/[email protected]/internal/api/lib.go:168 +0x2c7 fp=0xc0011475d8 sp=0xc0011473d0 pc=0x105b0e7
github.com/CosmWasm/wasmvm/v2.(*VM).AnalyzeCode(0x31e0380?, {0xc001aa8c60?, 0x324a1c8?, 0xc0013b8590?})
        /go/pkg/mod/github.com/!cosm!wasm/wasmvm/[email protected]/lib_libwasmvm.go:106 +0x2e fp=0xc001147610 sp=0xc0011475d8 pc=0x1069aee
github.com/CosmWasm/wasmd/x/wasm/keeper.Keeper.create({{0x31e0380, 0xc0000f82e8}, {0x324a1c8, 0xc0013b8590}, {0x31f5150, 0xc0010e4000}, {0x31e02e0, 0xc0015cc380}, {0x31e0160, 0xc0017f10c8}, ...}, ...)
        /workspaces/cosmwasgo/x/wasm/keeper/keeper.go:179 +0x6ba fp=0xc001148330 sp=0xc001147610 pc=0x244561a
github.com/CosmWasm/wasmd/x/wasm/keeper.(*Keeper).create(0x0?, {0x3211990?, 0xc000ff0e08?}, {0xc001aa83c0?, 0x0?, 0x0?}, {0x4b387e0?, 0x0?, 0x0?}, 0x0, ...)
        <autogenerated>:1 +0xda fp=0xc001148618 sp=0xc001148330 pc=0x252b57a
github.com/CosmWasm/wasmd/x/wasm/keeper.PermissionedKeeper.Create({{_, _}, {_, _}}, {{0x3211cd8, 0xc0015b2480}, {0x3228380, 0xc0015ae600}, {{0x0, 0x0}, ...}, ...}, ...)
        /workspaces/cosmwasgo/x/wasm/keeper/contract_keeper.go:57 +0xf0 fp=0xc0011486a8 sp=0xc001148618 pc=0x243b1b0
github.com/CosmWasm/wasmd/x/wasm/keeper.(*PermissionedKeeper).Create(_, {{0x3211cd8, 0xc0015b2480}, {0x3228380, 0xc0015ae600}, {{0x0, 0x0}, {0x0, 0x0}, 0x12d687, ...}, ...}, ...)
        <autogenerated>:1 +0xc5 fp=0xc001148a68 sp=0xc0011486a8 pc=0x2526585
github.com/CosmWasm/wasmd/x/wasm/keeper.TestCreateDuplicate(0xc001540340)
        /workspaces/cosmwasgo/x/wasm/keeper/keeper_test.go:296 +0x34d fp=0xc001149f70 sp=0xc001148a68 pc=0x24acc2d
testing.tRunner(0xc001540340, 0x2df9b10)
        /usr/local/go/src/testing/testing.go:1690 +0xf4 fp=0xc001149fc0 sp=0xc001149f70 pc=0x558214
testing.(*T).Run.gowrap1()
        /usr/local/go/src/testing/testing.go:1743 +0x25 fp=0xc001149fe0 sp=0xc001149fc0 pc=0x559205
runtime.goexit({})
        /usr/local/go/src/runtime/asm_amd64.s:1700 +0x1 fp=0xc001149fe8 sp=0xc001149fe0 pc=0x4821e1
created by testing.(*T).Run in goroutine 1
        /usr/local/go/src/testing/testing.go:1743 +0x390

when just repetetively running the tests

@faddat
Copy link
Contributor

faddat commented Oct 21, 2024

Clearing the cache might fix the strange build issue. Overall, I recommend moving to github actions.

What was in v2.1.3?

cause phew

Please note well that tests still fail intermittently with v2.1.3.

I notice that you are not updating this repository to v2.1.3:

is v2.2.0 the actual patch, but (more) state breaking?

My opinion is that running the tests ten times, should still produce a pass, but that's just not the case.

@kulikthebird
Copy link

Hey, the problems with the gas related test in WasmD are currently discussed, the test cases were already updated here: #2012. The only problem with updating wasmvm in wasmd is lack of libwasm.so library in the produced wasmvm 2.2.0-rc.1.

@faddat
Copy link
Contributor

faddat commented Oct 21, 2024

nah, this isn't that.

Take the main branch and run the test 20 times. You will get a pointer error. Make no code changes to the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants