Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle discount in setup costs for in memory cache contracts #1987

Merged
merged 9 commits into from
Sep 26, 2024

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented Sep 11, 2024

Resolves #1798

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 7 lines in your changes missing coverage. Please review.

Project coverage is 48.81%. Comparing base (2345840) to head (308018d).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
x/wasm/types/context.go 0.00% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1987      +/-   ##
==========================================
+ Coverage   48.63%   48.81%   +0.17%     
==========================================
  Files          65       65              
  Lines       10019    10079      +60     
==========================================
+ Hits         4873     4920      +47     
- Misses       4716     4725       +9     
- Partials      430      434       +4     
Files with missing lines Coverage Δ
app/ante.go 63.63% <100.00%> (+1.13%) ⬆️
x/wasm/keeper/ante.go 91.48% <100.00%> (+1.01%) ⬆️
x/wasm/keeper/keeper.go 77.72% <100.00%> (+0.44%) ⬆️
x/wasm/types/types.go 60.25% <100.00%> (+2.52%) ⬆️
x/wasm/types/context.go 13.88% <0.00%> (-3.36%) ⬇️

@pinosu pinosu changed the title Start work on setup costs for in memory cache contracts Handle discount in setup costs for in memory cache contracts Sep 13, 2024
@pinosu pinosu marked this pull request as ready for review September 13, 2024 10:33
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Can we test somehow that the TxContracts are reset correctly?

x/wasm/keeper/keeper.go Outdated Show resolved Hide resolved
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

x/wasm/keeper/keeper.go Outdated Show resolved Hide resolved
x/wasm/keeper/keeper.go Outdated Show resolved Hide resolved
x/wasm/types/types.go Outdated Show resolved Hide resolved
x/wasm/types/types.go Outdated Show resolved Hide resolved
x/wasm/keeper/ante.go Show resolved Hide resolved
x/wasm/keeper/keeper.go Outdated Show resolved Hide resolved
x/wasm/keeper/keeper.go Outdated Show resolved Hide resolved
x/wasm/types/types.go Show resolved Hide resolved
x/wasm/types/types.go Outdated Show resolved Hide resolved
@chipshort chipshort self-requested a review September 24, 2024 15:17
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just one doc comment then it's good to merge.

x/wasm/keeper/ante.go Show resolved Hide resolved
Co-authored-by: Christoph Otter <[email protected]>
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💐

@pinosu pinosu merged commit 02354c6 into main Sep 26, 2024
17 checks passed
@pinosu pinosu deleted the setup_cost_for_inmem_contract branch September 26, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve setup cost calculation
3 participants