Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add EurekaMsg #2340

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add EurekaMsg #2340

wants to merge 1 commit into from

Conversation

jawoznia
Copy link
Contributor

close #2339

@jawoznia jawoznia requested a review from aumetra January 14, 2025 16:28
aumetra
aumetra reviewed Jan 15, 2025
View reviewed changes
Copy link
Member

@aumetra aumetra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay. Seems reasonable. Changelog worthy maybe?

@chipshort
Copy link
Collaborator

The types look good.
Do we add this to CosmosMsg in a follow-up PR? Because otherwise that step is missing. After that the next step would be to adjust the wasmvm types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aumetra aumetra aumetra left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add EurekaMsg
3 participants
@jawoznia @chipshort @aumetra