Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JPMS Compatibility (Java 9+) #28

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

mintdaniel42
Copy link
Contributor

@mintdaniel42 mintdaniel42 commented Sep 25, 2024

This is required because otherwise it is impossible to use this library in a modularized java project. Another option would be to bump the minimum java version to 9 and create a module-info.class file

EDIT: other way would be a multi release jar following this guide: https://www.baeldung.com/java-multi-release-jar

EDIT2: The automatic module name should never ever be changed after 2.6.0 release because it would be a breaking change

@mintdaniel42
Copy link
Contributor Author

Checks failing doesn't seem to be related?

@amanteaux
Copy link
Member

Thank you for this PR.

I understand the issue and the need to have the Automatic-Module-Name line added to the manifest. I will just change this to put it in the Maven release pipeline rather than all the Maven build pipeline.

About the build issue, yes it is unrelated to this PR. I will try to fix that.

@amanteaux amanteaux merged commit 1bc8516 into Coreoz:master Oct 2, 2024
1 check failed
@mintdaniel42
Copy link
Contributor Author

Thank you so much 🙂 If you need any help let me know

@mintdaniel42
Copy link
Contributor Author

@amanteaux it seems not to be working as intended. If you want me to I'll take a look into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants