Added no_mp3_support argument and added a check for ffmpg installation #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ramalamadingdong , thank you for contributing a fix for #446. If we are going to distribute a sample mp3 with the repo, I'd prefer the reference audios from the SV2TTS audio samples page since they can also be used for trying out the toolbox and benchmarking. We can get all 6 "speaker adaptation for unseen speakers" reference audios for 100k total: samples.zip |
ghost
reviewed
Sep 2, 2020
There was a problem hiding this comment.
Looks pretty good @ramalamadingdong , please consider the suggestions that I have made.
Co-authored-by: blue-fish <[email protected]>
Co-authored-by: blue-fish <[email protected]>
Co-authored-by: blue-fish <[email protected]>
Co-authored-by: blue-fish <[email protected]>
Co-authored-by: blue-fish <[email protected]>
Co-authored-by: blue-fish <[email protected]>
Co-authored-by: blue-fish <[email protected]>
Co-authored-by: blue-fish <[email protected]>
Co-authored-by: blue-fish <[email protected]>
Co-authored-by: blue-fish <[email protected]>
|
Did the updates and uploaded the correct samples :D |
ghost
suggested changes
Sep 3, 2020
There was a problem hiding this comment.
In the future please make sure to test changes (the two that I found by testing escaped me during review).
- Please add a file called
samples/README.mdwith the following text. It is needed to comply with the requirements of the CC-BY-4.0 license.
The audio files in this folder are provided for toolbox testing and
benchmarking purposes. These are the same reference utterances
used by the SV2TTS authors to generate the audio samples located at:
https://google.github.io/tacotron/publications/speaker_adaptation/index.html
The `p240_00000.mp3` and `p260_00000.mp3` files are compressed
versions of audios from the VCTK corpus available at:
https://datashare.is.ed.ac.uk/handle/10283/3443
VCTK.txt contains the copyright notices and licensing information.
The `1320_00000.mp3`, `3575_00000.mp3`, `6829_00000.mp3`
and `8230_00000.mp3` files are compressed versions of audios
from the LibriSpeech dataset available at: https://openslr.org/12
For these files, the following notice applies:
```
LibriSpeech (c) 2014 by Vassil Panayotov
LibriSpeech ASR corpus is licensed under a
Creative Commons Attribution 4.0 International License.
See <http://creativecommons.org/licenses/by/4.0/>.
```
- Please download README.txt from https://datashare.is.ed.ac.uk/handle/10283/3443 and import that to the repo as
samples/VCTK.txt
Co-authored-by: blue-fish <[email protected]>
Co-authored-by: blue-fish <[email protected]>
ghost
approved these changes
Sep 3, 2020
ghost
requested a review
from 
CorentinJ
approved these changes
Sep 3, 2020
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for this issue Please let me know if anything else needs to get done