Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handles the Failed Imports #5

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Handles the Failed Imports #5

wants to merge 2 commits into from

Conversation

nardotago-on-cp
Copy link
Collaborator

@nardotago-on-cp nardotago-on-cp commented Jan 9, 2025 •
edited
Loading

Fixes for https://github.com/CoreProc/pmftc-appwards-wholesaler-web/issues/581

What changed?

  • Added Handle if Import has failed

How can it be tested?

  • Import specifically in TargetRewards

What are possible test scenarios?

  • Import still working as expected (Already tested in Local only)

{1443011E-7508-4036-AFFD-88CB9DA462E2}

chrisbjr
chrisbjr reviewed Jan 17, 2025
View reviewed changes
src/Import/Jobs/BulkImportProcessor.php
@@ -49,6 +49,21 @@ public function handle(): void
return;
}

try {
$this->process();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dito na natin execute yung $this->process()? saan ba siya before?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myraoliveros-cp myraoliveros-cp myraoliveros-cp left review comments

@chrisbjr chrisbjr chrisbjr left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nardotago-on-cp @chrisbjr @myraoliveros-cp