Refreshed and improved to support config less repos, key libs and be more resilient #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beta tested on components ⬆️ About to bump node version: - Write package.json - Write .nvmrc - Write .travis.yml - Write packages/@coorpacademy-app-review/package.json - Write packages/@coorpacademy-components/package.json - Write packages/@coorpacademy-css-modules-require-hook/package.json - Write packages/@coorpacademy-nova-icons/package.json - Write packages/@coorpacademy-history/package.json - Write packages/@coorpacademy-player-services/package.json - Write packages/@coorpacademy-player-store/package.json - Write packages/@coorpacademy-player-web/package.json - Write packages/@coorpacademy-progression-engine/package.json - Write packages/@coorpacademy-react-adapter-angular/package.json - Write packages/@coorpacademy-react-adapter-dust/package.json - Write packages/@coorpacademy-react-native-animation/package.json - Write packages/@coorpacademy-redux-history/package.json - Write packages/@coorpacademy-redux-router/package.json - Write packages/@coorpacademy-redux-task/package.json - Write packages/@coorpacademy-review-services-mocks/package.json - Write packages/@coorpacademy-review-services/package.json - Write packages/@coorpacademy-translate/package.json - Write packages/@coorpacademy-webpack-config/package.json + Successfully bumped Node version to v20.17.0
And infer default config master/main/wgatever asking git
StefanoA1
reviewed
Oct 9, 2024
StefanoA1
reviewed
Oct 9, 2024
StefanoA1
reviewed
Oct 9, 2024
StefanoA1
reviewed
Oct 9, 2024
StefanoA1
reviewed
Oct 9, 2024
StefanoA1
approved these changes
Oct 9, 2024
StefanoA1
approved these changes
Oct 10, 2024
Mainly lerna related ones. Saw creating this PR: CoorpAcademy/coorpacademy-private-libraries#161
silouone
reviewed
Oct 11, 2024
silouone
approved these changes
Oct 11, 2024
StefanoA1
approved these changes
Oct 11, 2024
StefanoA1
reviewed
Oct 11, 2024
| exit 2 | ||
| fi | ||
| if [[ ! -f $POST_CLEAN_COMMAND_FILE ]]; then | ||
| echo "Seems like pre command wasnt run" |
There was a problem hiding this comment.
Suggested change
| echo "Seems like pre command wasnt run" | |
| echo "Seems like post command wasnt run" |
AdrieanKhisbe
added a commit
that referenced
this pull request
Oct 21, 2024
Merge pull request #148 from CoorpAcademy/refreshed-and-improved--more-more #143 and #147 follow up, with few enhancement and glitch fixes - Sync the package-lock (by default, and with node nvm version loaded) 🔄 - Add hook `-b`/`--pre-commit-bump-command` to inject commands (like updating a specific package with `ncu`) 🪝 - Restore force push for the autobump ⛑️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New huge set of enhancements to the project, following #143 with main goal to make this usable on project with no prior config, and handle command lib with adherence to node version (lerna and serverless).
Also program was improved not to require a clean state before running.
Less config is needed, the program can be run out of the box on any node repository
Exemple of command ran: (that boostrapped that PR: https://github.com/CoorpAcademy/coorpacademy-lambda/pull/1590)
update-node upgrade --target 20 -dcam "Update-node major bump :outbox_tray:" -R @Coorpacademy/development-mooc -F api-media -s mediaflags:
dfor default config 🆕 7eb2685cfor clean, cleanup before running 🆕 c6e0220afor autofigure what to dotarget(t) to search to bump for a specific node version (from Refreshed and improved to support bootstraping of major upgrade PR 🚀 #143)Fto target a folder (was ran fromcoorpacademy-lambdaroot (from Refreshed and improved to support bootstraping of major upgrade PR 🚀 #143)stoscopein monorepo (scoped added in title and branch name) 🆕 a1faa74Rto set reviewer (from Refreshed and improved to support bootstraping of major upgrade PR 🚀 #143)serverless+lerna support: Serverless runtime will be updated, and every package in a lerna mono repo will be updated ⚡🐲 8fffb7f + 22dcf55
Some adjustement where also made for the program to be more flexible with the baseBranch, supporting non
masterbranches