Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prefix bytes #21

Closed

Conversation

icambron
Copy link

This is a "fix" for #18. I suspect it's wrong.

I couldn't get Chrome to accept my extension. I noticed that the CRXs that Chrome generates have 296-byte keys, but crxmake generates 316-byte keys because it tacks 22 bytes to the front of the key I provided. I removed the code that does that and now my extension works.

I suspect what's happening is that my key is coming with the right ceremonial prefix in it, but that crxmake isn't recognizing it as "correct" and thus tacking on its own, thereby breaking things. Perhaps my fix breaks other things, such as keys generated by crxmake itself (I didn't try it). I don't really know how this stuff works, what the prefix really does, or why it would be constant (seems a bit odd).

@cielavenir
Copy link
Contributor

That's quite strange. This code (modified crxmake) is working flawlessly.
https://github.com/cielavenir/ctouch/blob/master/support/crx.rb

@icambron icambron closed this Feb 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants