Add graph based on for time period comparison

[dimasciput]

For #856

Screen.Recording.2024-12-01.at.14.54.37.mov

[dimasciput]

Added graph for progress period :

Screen.Recording.2024-12-03.at.14.20.11.mov

[azvoleff]

Thanks! Flagging @boc84 for his review as well

[boc84]

Looks good. My first comment is about the terminology. I am not sure if we will be using the term "Progress" or ""SDG Status" anymore but this under discussion and not likely resolved until next year. I wonder could we maintain the functionality as is but allow flexibility to change the text later.

Secondly, if you check the first slide on this PPT, in the "old" way of calculating the SDG we used the full 20-year time series for SOC change in the reporting period. Please make sure this is possible in the current implementation.

Thirdly, are there constraints on the min and max year a country can report for either period? For example, should we prevent years beyond 2023 being selected? Or enforce a maximum number of years between initial and final years for a given dataset?
Default_Data_SDG_Progress_Calculation (003).pptx

[dimasciput]

@boc84

Thank you for the feedback!

I wonder could we maintain the functionality as is but allow flexibility to change the text later.

Yes, this can be easily updated. I already have a variable set up for the title.

Secondly, if you check the first slide on this PPT, in the "old" way of calculating the SDG, we used the full 20-year time series for SOC change in the reporting period. Please make sure this is possible in the current implementation.

This is indeed possible in the current implementation.

Thirdly, are there constraints on the minimum and maximum years a country can report for either period? For example, should we prevent years beyond 2023 from being selected, or enforce a maximum number of years between the initial and final years for a given dataset?

I’m currently following the previous constraints. For this ticket, the focus is mainly on the graph, which will automatically align with the dropdown selections. Technically, we can allow years beyond 2023, but handling that would be better suited for a separate ticket.

[Samweli]

LGTM!

[Samweli]

@azvoleff @gabrieldaldegan @dimasciput I'm +1 on making these changes in a new separate dialog rather into a description panel as it is currently done.

[gdaldegan]

Thanks Dimas for developing and implementing the graphical visualization, it's looking quite good! Glad that Brian already flagged that there might be some minor adjustments on the terms. As for limiting/enforcing the tool to reflect the UNCCD official baseline and/or reporting periods, my take is that we keep Trends.Earth flexible so users can pick any dates as they wish. Although Trends.Earth is designed to support countries to run analysis and prepare data for official reporting to UNCCD, we also have a large community of users that do not use the tool for that purpose, and enforcing dates would hinder those analysis.

[gdaldegan]

@azvoleff @gabrieldaldegan @dimasciput I'm +1 on making these changes in a new separate dialog rather into a description panel as it is currently done.

could you please argue for the pros and cons of each approach? Having it within the description panel obviously have implications for visualizing the graphs when working on a small screen such as a laptop.

[Samweli]

@azvoleff @gabrieldaldegan @dimasciput I'm +1 on making these changes in a new separate dialog rather into a description panel as it is currently done.

could you please argue for the pros and cons of each approach? Having it within the description panel obviously have implications for visualizing the graphs when working on a small screen such as a laptop.

@gabrieldaldegan having it on a different dialog will decouple the new functionality from the algorithm dialog, provide enough space for future features expansion/addition, fix responsiveness issues and better UI components management. One of the cons is that user will need one extra click in order to access the functionality.

[mvmaltitz]

@dimasciput

From Gabriel in email on 10 Jan 2025:
Regarding the point 3 below on the graphical tool for visualizing the time span of each sub-indicator and final SDG 15.3.1 Indicator, I left comments in Github and am convinced that it would be better to have it on a separate dialog, Thanks Samweli for your inputs and please go ahead with that implementation.

[dimasciput]

@Samweli @gabrieldaldegan @gdaldegan here's the updated timeline view :

Screen.Recording.2025-01-17.at.14.26.53.mov

[azvoleff]

@gabrieldaldegan have you tested/confirmed this one?

[gdaldegan]

@Samweli, please share a zipfile to test this updated function

[Samweli]

@Samweli, please share a zipfile to test this updated function

@gdaldegan here it is https://github.com/ConservationInternational/trends.earth/actions/runs/12830984190/artifacts/2447280066.

[Samweli]

@gdaldegan I have also attached a gif here that shows how to grab a plugin zip file for any pull request.

[gdaldegan]

@gdaldegan I have also attached a gif here that shows how to grab a plugin zip file for any pull request.

great, thanks @Samweli