Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getcidr for GCE #258

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Fix getcidr for GCE #258

merged 1 commit into from
Sep 20, 2023

Conversation

cmd-ntrf
Copy link
Member

Puppet "network" fact is equal to the ip address since the netmask is wrong.

To get the cidr correctly, we retrieve the correct netmask from GCE facts, compute the len, then use the extlib to compute the network ip.

This PR also replace old yelp netstdlib dependency by extlib.

@cmd-ntrf cmd-ntrf self-assigned this Sep 20, 2023
@cmd-ntrf cmd-ntrf merged commit 194bf44 into main Sep 20, 2023
2 checks passed
@cmd-ntrf cmd-ntrf deleted the fix_network_functions branch September 29, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant