Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New content for ReactionDiffusionSolverFE & Boundary Conditions pages; removed orphaned section pages #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fyffep
Copy link
Collaborator

@fyffep fyffep commented Oct 15, 2024

Changes made:

  1. Overhauled ReactionDiffusionSolverFE
  2. Added 2 Boundary Conditions pages
  3. Removed orphaned section pages. These contained duplicate content of similarly-named pages (e.g. section_tutorials.rst and tutorials_section.rst)
  4. Added many more hyperlinks to clarify technical jargon.

Addresses #29 .

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GIFs are very useful, but I add 636 KB with just these 2 files. Should I work to reduce the image quality, or is this not much of a concern?

Comment on lines +68 to +70
* **Element** ``<InitialConcentrationExpression>`` (optional)
* Contains a `muParser expression <mu_parser.html>`_ to define the level of concentration at each voxel on MCS 0.
* We recommend using either InitialConcentrationExpression or ConcentrationFileName but not both.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not confirm that InitialConcentrationExpression is a part of ReactionDiffusionSolverFE. It seems to be present in all of the other PDE solvers, however.

Comment on lines +1 to +2
Boundary Conditions for Cells
##############################
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is somewhat duplicate content from potts.rst, but I think it's valuable to have smaller quick reference pages like this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant