sealable-trie: don’t use varint for tag #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using varints for the length of proof isn’t worth it in the end. The proof will never be longer than 8192 elements (longest possible key is 512 bytes long) and even with the additional bit for distinguishing membership from non-membership proofs 16-bits is enough to encode it. Using varint to encode the tag saves us at most only one byte at the cost of having bunch of convoluted code.
blasrodri
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using varints for the length of proof isn’t worth it in the end. The
proof will never be longer than 8192 elements (longest possible key is
512 bytes long) and even with the additional bit for distinguishing
membership from non-membership proofs 16-bits is enough to encode it.
Using varint to encode the tag saves us at most only one byte at the
cost of having bunch of convoluted code.