solana-ibc: fix lack of client id checking and add client references #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firstly, and most importantly, add a missing client_id check in PrivateStorage::client_mut method. When getting an existing client we must check that the client id given as argument matches the one stored in the ClientStore. PrivateStorage::client performed that check alas, PrivateStorage::client_mut lacked it. Add it as required. Secondly, introduce ClientRef and ClientMut reference types which replace previously used pairs. Those type clarify some of the code by naming the index field and simplify other code by removing the need for `.1` to get the reference. Issue: #35
dhruvja
approved these changes
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, and most importantly, add a missing client_id check in
PrivateStorage::client_mut method. When getting an existing client we
must check that the client id given as argument matches the one stored
in the ClientStore. PrivateStorage::client performed that check alas,
PrivateStorage::client_mut lacked it. Add it as required.
Secondly, introduce ClientRef and ClientMut reference types which
replace previously used pairs. Those type clarify some of the code by
naming the index field and simplify other code by removing the need
for
.1to get the reference.Issue: #35