-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Automatus Sanity Pass #12590
Make Automatus Sanity Pass #12590
Conversation
Make testing pass for symlinks
Code Climate has analyzed commit dc64896 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 60.9% (0.0% change). View more on Code Climate. |
Thank you for the fix. I understand this fixes the thing from the point of the test scenario, but shouldn't the OVAL handle symlink situation? I mean, I am fine with merging this, but do you think it is worth creating an issue against the template? |
The OVAL check just skips symlinks so that is why I changed to change the symlink to an actual file. We can create an issue on this template, but it will involve a lot of thinking about what we want this template to do. |
With the recent release of F41, that F39 check might never finish. Should be fine to merge without it. |
OK. I will create an issue for the template. Othervise LGTM, thank you. |
33a7ba2
into
ComplianceAsCode:master
fyi: #12601 |
Description:
Make Automatus Sanity pass by adjusting how symlinks work in the failing test.
Rationale:
Make CI green.