Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Automatus Sanity Pass #12590

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Nov 7, 2024

Description:

Make Automatus Sanity pass by adjusting how symlinks work in the failing test.

Rationale:

Make CI green.

@Mab879 Mab879 added the Test Suite Update in Test Suite. label Nov 7, 2024
@Mab879 Mab879 added this to the 0.1.76 milestone Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Nov 7, 2024

Code Climate has analyzed commit dc64896 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

@vojtapolasek
Copy link
Collaborator

Thank you for the fix. I understand this fixes the thing from the point of the test scenario, but shouldn't the OVAL handle symlink situation? I mean, I am fine with merging this, but do you think it is worth creating an issue against the template?

@vojtapolasek vojtapolasek self-assigned this Nov 8, 2024
@Mab879
Copy link
Member Author

Mab879 commented Nov 8, 2024

Thank you for the fix. I understand this fixes the thing from the point of the test scenario, but shouldn't the OVAL handle symlink situation? I mean, I am fine with merging this, but do you think it is worth creating an issue against the template?

The OVAL check just skips symlinks so that is why I changed to change the symlink to an actual file. We can create an issue on this template, but it will involve a lot of thinking about what we want this template to do.

@Mab879
Copy link
Member Author

Mab879 commented Nov 8, 2024

With the recent release of F41, that F39 check might never finish.

Should be fine to merge without it.

@vojtapolasek
Copy link
Collaborator

OK. I will create an issue for the template. Othervise LGTM, thank you.

@vojtapolasek vojtapolasek merged commit 33a7ba2 into ComplianceAsCode:master Nov 12, 2024
104 of 105 checks passed
@vojtapolasek
Copy link
Collaborator

fyi: #12601

@Mab879 Mab879 deleted the fix_automatus_sanity branch November 12, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Suite Update in Test Suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants