-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defined notes for BSI SYS.1.6.A15 #12528
base: master
Are you sure you want to change the base?
Defined notes for BSI SYS.1.6.A15 #12528
Conversation
Hi @lichtblaugue. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This datastream diff is auto generated by the check Click here to see the full diffNew content has different text for rule 'xccdf_org.ssgproject.content_rule_project_config_and_template_resource_quota'.
--- xccdf_org.ssgproject.content_rule_project_config_and_template_resource_quota
+++ xccdf_org.ssgproject.content_rule_project_config_and_template_resource_quota
@@ -47,6 +47,9 @@
SRG-APP-000435-CTR-001070
[reference]:
+SYS.1.6.A15
+
+[reference]:
CNTR-OS-000620
[reference]:
New content has different text for rule 'xccdf_org.ssgproject.content_rule_project_template_resource_quota'.
--- xccdf_org.ssgproject.content_rule_project_template_resource_quota
+++ xccdf_org.ssgproject.content_rule_project_template_resource_quota
@@ -32,6 +32,9 @@
[reference]:
SRG-APP-000246-CTR-000605
+[reference]:
+SYS.1.6.A15
+
[rationale]:
Running different applications on the same Kubernetes cluster creates a risk of
a "noisy neighbor" when one application monopolizes cluster resources.
New content has different text for rule 'xccdf_org.ssgproject.content_rule_resource_requests_limits_in_daemonset'.
--- xccdf_org.ssgproject.content_rule_resource_requests_limits_in_daemonset
+++ xccdf_org.ssgproject.content_rule_resource_requests_limits_in_daemonset
@@ -26,6 +26,9 @@
[reference]:
SC-6
+[reference]:
+SYS.1.6.A15
+
[rationale]:
Resource requests/limits provide constraints that limit aggregate resource consumption
per container. This helps prevent resource starvation. When deploying your
New content has different text for rule 'xccdf_org.ssgproject.content_rule_resource_requests_limits_in_deployment'.
--- xccdf_org.ssgproject.content_rule_resource_requests_limits_in_deployment
+++ xccdf_org.ssgproject.content_rule_resource_requests_limits_in_deployment
@@ -26,6 +26,9 @@
[reference]:
SC-6
+[reference]:
+SYS.1.6.A15
+
[rationale]:
Resource requests/limits provide constraints that limit aggregate resource consumption
per container. This helps prevent resource starvation. When deploying your
New content has different text for rule 'xccdf_org.ssgproject.content_rule_resource_requests_limits_in_statefulset'.
--- xccdf_org.ssgproject.content_rule_resource_requests_limits_in_statefulset
+++ xccdf_org.ssgproject.content_rule_resource_requests_limits_in_statefulset
@@ -26,6 +26,9 @@
[reference]:
SC-6
+[reference]:
+SYS.1.6.A15
+
[rationale]:
Resource requests/limits provide constraints that limit aggregate resource consumption
per container. This helps prevent resource starvation. When deploying your
New content has different text for rule 'xccdf_org.ssgproject.content_rule_resource_requests_quota'.
--- xccdf_org.ssgproject.content_rule_resource_requests_quota
+++ xccdf_org.ssgproject.content_rule_resource_requests_quota
@@ -57,6 +57,9 @@
[reference]:
SC-5(2)
+[reference]:
+SYS.1.6.A15
+
[rationale]:
Resource quotas provide constraints that limit aggregate resource consumption
per project. This helps prevent resource starvation. When deploying your
New content has different text for rule 'xccdf_org.ssgproject.content_rule_resource_requests_quota_cluster'.
--- xccdf_org.ssgproject.content_rule_resource_requests_quota_cluster
+++ xccdf_org.ssgproject.content_rule_resource_requests_quota_cluster
@@ -45,6 +45,9 @@
[reference]:
SC-5(2)
+[reference]:
+SYS.1.6.A15
+
[rationale]:
Resource quotas provide constraints that limit aggregate resource consumption
per project. This helps prevent resource starvation. When deploying your
New content has different text for rule 'xccdf_org.ssgproject.content_rule_resource_requests_quota_per_project'.
--- xccdf_org.ssgproject.content_rule_resource_requests_quota_per_project
+++ xccdf_org.ssgproject.content_rule_resource_requests_quota_per_project
@@ -64,6 +64,9 @@
SRG-APP-000450-CTR-001105
[reference]:
+SYS.1.6.A15
+
+[reference]:
CNTR-OS-000620
[reference]: |
|
||
identifiers: | ||
|
||
references: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you do not need references (with the BSI profile you dont because they are automatically generated) just remove the key.
|
||
severity: unknown | ||
|
||
identifiers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add an identifier
./utils/rule_dir_json.py
followed by python utils/fix_rules.py --product products/ocp4/product.yml add-cce --cce-pool redhat configure_network_bandwidth
rationale: |- | ||
Network bandwidth is limited at the pod level and can be determined separately according | ||
to incoming and outgoing network bandwidth. | ||
For more information about limiting Pod bandwidth on OCP 4 please refer to the Red Hat documentation: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For more information about limiting Pod bandwidth on OCP 4 please refer to the Red Hat documentation: | |
For more information about limiting network bandwidth on the pod level please refer to the Red Hat documentation: |
Network bandwidth is limited at the pod level and can be determined separately according | ||
to incoming and outgoing network bandwidth. | ||
For more information about limiting Pod bandwidth on OCP 4 please refer to the Red Hat documentation: | ||
{{{ weblink(link="https://access.redhat.com/solutions/5018951") }}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{{ weblink(link="https://access.redhat.com/solutions/5018951") }}} | |
{{{ weblink(link="https://docs.openshift.com/container-platform/4.17/nodes/pods/nodes-pods-configuring.html#nodes-pods-configuring-bandwidth_nodes-pods-configuring") }}} |
description: |- | ||
Network bandwidth, SHOULD be appropriately reserved and limited. | ||
|
||
rationale: |- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rationale: |- | |
ocil: |- |
|
||
ocil_clause: 'Limiting Pod bandwidth on OCP 4' | ||
|
||
ocil: |- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ocil: |- | |
rationale: |- |
please add content on WHY this helps to secure the cluster or make the cluster more compliant.
Something around the lines:
"to prevent a bad actor or a malfunction in the pod to consume all the bandwidth in the cluster, a network bandwidth limitation on the pod level can mitigate the bearing onto the cluster.
Code Climate has analyzed commit 22df150 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 60.9% (0.0% change). View more on Code Climate. |
Description:
Adding serveral existing rules and one manual rule for checking this requirement.
Rationale:
As we have multiple customers asking for a BSI profile to be included in the compliance-operator, we are contributing a profile. To provide a better review process, the individual controle are implemented as separate PRs.