Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-304: Fix jq filters for resource request limits #12382

Merged

Conversation

yuumasato
Copy link
Member

Description:

Rationale:

@yuumasato yuumasato added the OpenShift OpenShift product related. label Sep 16, 2024
@yuumasato yuumasato added this to the 0.1.75 milestone Sep 16, 2024
@yuumasato
Copy link
Member Author

/test 4.15-e2e-aws-ocp4-moderate
/test 4.16-e2e-aws-ocp4-moderate
/test 4.17-e2e-aws-ocp4-moderate

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@yuumasato
Copy link
Member Author

@Vincent056 The jqfilter change was somehow reverted in the PR and this needs to be added.

Copy link

github-actions bot commented Sep 16, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12382
This image was built from commit: abc5768

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12382

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12382 make deploy-local

These changes were probably lost during PR rebase.
@yuumasato yuumasato force-pushed the update-jqfilters-resource-limits branch from 08c3f94 to abc5768 Compare September 16, 2024 14:50
@yuumasato
Copy link
Member Author

/test 4.15-e2e-aws-ocp4-moderate
/test 4.16-e2e-aws-ocp4-moderate
/test 4.17-e2e-aws-ocp4-moderate

Copy link
Contributor

@Vincent056 Vincent056 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks for the fix! waiting to get a green CI

Copy link

codeclimate bot commented Sep 16, 2024

Code Climate has analyzed commit abc5768 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.5% (0.0% change).

View more on Code Climate.

Copy link

openshift-ci bot commented Sep 16, 2024

@yuumasato: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.17-e2e-aws-ocp4-moderate abc5768 link true /test 4.17-e2e-aws-ocp4-moderate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@yuumasato
Copy link
Member Author

Failures of ci/prow/4.17-e2e-aws-ocp4-moderate are unrelated to the changes in this PR.

@yuumasato yuumasato changed the title Fix jq filters for resource request limits OCPBUGS-304: Fix jq filters for resource request limits Sep 16, 2024
Copy link
Collaborator

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rhmdnd rhmdnd merged commit 39614ff into ComplianceAsCode:master Sep 16, 2024
99 of 103 checks passed
@yuumasato yuumasato deleted the update-jqfilters-resource-limits branch September 17, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OpenShift OpenShift product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants