Updated min and target SDKs and removed redundant conditional execution paths. #3478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on paths. Removed any WinJS reference.
|
Thanks azchohfi for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested a review
from 
ghost
added
Sergio0694
approved these changes
Sep 17, 2020
...oolkit.Uwp.SampleApp/SamplePages/WeatherLiveTileAndToast/WeatherLiveTileAndToastPage.xaml.cs
Outdated
Show resolved
Hide resolved
Microsoft.Toolkit.Uwp.UI.Controls/TokenizingTextBox/TokenizingTextBoxItem.AutoSuggestBox.xaml
Outdated
Show resolved
Hide resolved
andrewleader
approved these changes
Sep 17, 2020
7 tasks
michael-hawker
requested changes
Sep 21, 2020
Microsoft.Toolkit.Uwp.SampleApp/SamplePages/ImageEx/ImageExPage.xaml.cs
Outdated
Show resolved
Hide resolved
Microsoft.Toolkit.Uwp.UI.Controls/InAppNotification/InAppNotification.xaml
Outdated
Show resolved
Hide resolved
Rosuavio
reviewed
Sep 22, 2020
...t.Toolkit.Uwp.SampleApp/SamplePages/WeatherLiveTileAndToast/WeatherLiveTileAndToastCode.bind
Show resolved
Hide resolved
|
This PR has been marked as "needs attention 👋" and awaiting a response from the team. |
…e.xaml.cs Co-authored-by: Michael Hawker MSFT (XAML Llama) <[email protected]>
Co-authored-by: Michael Hawker MSFT (XAML Llama) <[email protected]>
michael-hawker
approved these changes
Sep 22, 2020
|
Hello @michael-hawker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, removed any WinJS reference.
Fixes #3440
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Target SDK = 18362
Min SDK = 16299
What is the new behavior?
Target SDK = 19041
Min SDK = 17763
PR Checklist
Please check if your PR fulfills the following requirements:
This PR does have breaking changes, as expected by #3062.