Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XamlRoot being set incorrectly in Popup Handler #2476

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

ne0rrmatrix
Copy link
Contributor

@ne0rrmatrix ne0rrmatrix commented Jan 28, 2025

Description of Change

This fixes incorrect XamlRoot being set when application uses modal navigation and opens a popup. The current behavior results in application crashing. This sets the XamlRoot correctly and the app does not crash. Additionally made a cosmetic size change to sizing for large popup as it is too large and covers the whole window in some situations in Multiple Popups Page.

Linked Issues

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

Currently the windows implementation of Popup has the xaml root set incorrectly. I updated the XamlRoot in the handler for Popup to fix the issue. The linked issue has a CTD when using modal navigation and opening a Popup.

@TheCodeTraveler TheCodeTraveler merged commit 2ac604e into CommunityToolkit:main Jan 29, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Popup is not working on Windows whe opend from a modal
3 participants