-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Snackbar layout #1901 #2456
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (1)
- samples/CommunityToolkit.Maui.Sample/Pages/Alerts/SnackbarPage.xaml: Language not supported
Comments suppressed due to low confidence (2)
src/CommunityToolkit.Maui.Core/Views/Alert/AlertView.macios.cs:60
- Ensure that the new layout behavior introduced in LayoutSubviews is covered by tests.
public override void LayoutSubviews()
samples/CommunityToolkit.Maui.Sample/Pages/Alerts/SnackbarPage.xaml.cs:85
- [nitpick] The method name 'DisplayCustomSnackbarButtonClicked2' is ambiguous and should be renamed to something more descriptive, such as 'DisplayCustomSnackbarWithOptions'.
async void DisplayCustomSnackbarButtonClicked2(object sender, EventArgs e)
3000b06
to
ee5b86c
Compare
3ddb104
to
16919f7
Compare
`DisplayCustomSnackbarButtonWithAndchor` is used to demonstrate setting an Anchor on a Snackbar
…it/Maui into 1901-fix-snackbar
…e, Update Displayed text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
samples/CommunityToolkit.Maui.Sample/Pages/Alerts/SnackbarPage.xaml.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (2)
- samples/CommunityToolkit.Maui.Sample/Pages/Alerts/SnackbarPage.xaml: Language not supported
- src/CommunityToolkit.Maui.Core/Views/Toast/PlatformToast.macios.cs: Evaluated as low risk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very well done! Just need to fix that IOS bug and it will be good to merge. The issue was listed previously by the @TheCodeTraveler. Once that is cleared i will be happy to approve this. The look and feel is now consistant across both android and ios.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look. Good I have tested them on IOS and the crash is no longer an issue. Only one minor bug that might be nice to fix before merge.
Description of Change
Linked Issues
PR Checklist
approved
(bug) orChampioned
(feature/proposal)main
at time of PRAdditional information