-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GitHub Actions #2091
Use GitHub Actions #2091
Conversation
93a203e
to
b8d63a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start!
I think we need two more things:
Both of these I think will be very similar to what Windows does. They have stages already set up and the secrets they are using are org secrets, so those should be available to us.
We "just" need to check the conditions here and make sure that they match out release procedure with creating a git tag and then using the version number from that.
b8d63a7
to
c56245e
Compare
Can we check to see what code coverage reports we will get? Well we be getting similar to what we get from Azure DevOps? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 3 changed files in this pull request and generated no suggestions.
Files not reviewed (1)
- .github/workflows/SignClientFileList.txt: Language not supported
9999eea
to
3480ce4
Compare
Keeping the azure-pipelines.yml around for a little bit more until we know the GitHub Actions do everything they should. Mostly releases. I can basically only test the sign and release part by actually doing a release and when that turns out to not work, I'd rather be able to revert back to Azure Pipelines to get the release out and fix it for a next time. |
Description of Change
Initial migration from Azure Pipeline to GitHub Actions.
Skipped NuGet publish.
Linked Issues
PR Checklist
approved
(bug) orChampioned
(feature/proposal)main
at time of PRAdditional information