Popup V2 #1581
Popup V2 #1581
Conversation
|
I have ended up rewriting at least 3 or 4 samples submitted as bugs using standard DI pattern because the code would crash in IOS 17.x. I wanted to verify the issues that were being reported. If I see a bunch of different reports I put extra effort in. Simplifying implementation would be great. I am all for that. |
TheCodeTraveler
removed
the
needs discussion
|
There are currently a couple of breaking changes to the await popupService.ShowPopupAsync<MockPageViewModel>(CancellationToken.None);becomes await popupService.ShowPopupAsync<MockPageViewModel>(token: CancellationToken.None);await Assert.ThrowsAsync<TaskCanceledException>(() => popupService.ShowPopupAsync<MockPageViewModel>(viewModel => viewModel.HasLoaded = true, cts.Token));becomes await Assert.ThrowsAsync<TaskCanceledException>(() => popupService.ShowPopupAsync<MockPageViewModel>(viewModel => viewModel.HasLoaded = true, token: cts.Token));It also involves removing the ability to supply a |
|
@bijington FYI - we now have a few merge conflicts on this PR after merging a bunch of Popup PRs today |
dotnet-policy-service
bot
added
stale
bijington
removed
help wanted
bijington
changed the title
dotnet-policy-service
bot
added
stale
There was a problem hiding this comment.
Copilot reviewed 5 out of 11 changed files in this pull request and generated no suggestions.
Files not reviewed (6)
- samples/CommunityToolkit.Maui.Sample/Pages/Views/Popup/MultiplePopupPage.xaml: Language not supported
- samples/CommunityToolkit.Maui.Sample/Views/Popups/PopupContentView.xaml: Language not supported
- samples/CommunityToolkit.Maui.Sample/MauiProgram.cs: Evaluated as low risk
- samples/CommunityToolkit.Maui.Sample/ViewModels/Views/Popup/MultiplePopupViewModel.cs: Evaluated as low risk
- samples/CommunityToolkit.Maui.Sample/ViewModels/Views/Popup/PopupContentViewModel.cs: Evaluated as low risk
- samples/CommunityToolkit.Maui.Sample/Views/Popups/PopupContentView.xaml.cs: Evaluated as low risk
VladislavAntonyuk
force-pushed
the
feature/sl/remove-popup-constraint-from-popup-service
branch
from
c1488d0 to
ebc39f2
Compare
…able properties The aim is to allow us to hide the Popup away from developers, or at least simply the usage of showing a popup to not needing to create a Popup implementation
VladislavAntonyuk
force-pushed
the
feature/sl/remove-popup-constraint-from-popup-service
branch
from
aeb9020 to
94bee57
Compare
There was a problem hiding this comment.
Good job! I didn't run locally yet, just reviewed the code.
I saw that you removed the old popups reference, and I think we should mark them as obsolete and let them live for a while before removing everything. At least is what I remember from the last standup.
There was a problem hiding this comment.
Copilot reviewed 81 out of 96 changed files in this pull request and generated no comments.
Files not reviewed (15)
- samples/CommunityToolkit.Maui.Sample/App.xaml: Language not supported
- samples/CommunityToolkit.Maui.Sample/Pages/Views/Popup/MultiplePopupPage.xaml: Language not supported
- samples/CommunityToolkit.Maui.Sample/Resources/Styles/Styles.xaml: Language not supported
- samples/CommunityToolkit.Maui.Sample/Models/PopupSize.cs: Evaluated as low risk
- samples/CommunityToolkit.Maui.Sample/AppShell.xaml.cs: Evaluated as low risk
- samples/CommunityToolkit.Maui.Sample/ViewModels/Views/Popup/PopupSizingIssuesViewModel.cs: Evaluated as low risk
- samples/CommunityToolkit.Maui.Sample/ViewModels/Views/Popup/StylePopupViewModel.cs: Evaluated as low risk
- samples/CommunityToolkit.Maui.Sample/ViewModels/Views/Popup/PopupPositionViewModel.cs: Evaluated as low risk
- samples/CommunityToolkit.Maui.Sample/ViewModels/Views/Popup/CustomSizeAndPositionPopupViewModel.cs: Evaluated as low risk
- samples/CommunityToolkit.Maui.Sample/ViewModels/Views/Popup/UpdatingPopupViewModel.cs: Evaluated as low risk
- samples/CommunityToolkit.Maui.Sample/Pages/Views/MediaElement/MediaElementPage.xaml.cs: Evaluated as low risk
- samples/CommunityToolkit.Maui.Sample/Pages/Views/Popup/PopupLayoutAlignmentPage.xaml.cs: Evaluated as low risk
- samples/CommunityToolkit.Maui.Sample/Pages/Views/Popup/ShowPopupInOnAppearingPage.xaml.cs: Evaluated as low risk
- samples/CommunityToolkit.Maui.Sample/ViewModels/Views/ViewsGalleryViewModel.cs: Evaluated as low risk
- samples/CommunityToolkit.Maui.Sample/ViewModels/Views/Popup/PopupAnchorViewModel.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
samples/CommunityToolkit.Maui.Sample/ViewModels/Views/Popup/PopupContentViewModel.cs:8
- The property name 'message' should be renamed to 'Message' to follow PascalCase convention.
string message = "";
https://github.com/CommunityToolkit/Maui into feature/sl/remove-popup-constraint-from-popup-service
| return popupService.ShowPopupAsync<CsharpBindingPopupViewModel>( | ||
| onPresenting: viewModel => viewModel.Load("This is a platform specific popup with a .NET MAUI View being rendered. The behaviors of the popup will confirm to 100% this platform look and feel, but still allows you to use your .NET MAUI Controls."), | ||
| token); | ||
| return popupService.ShowPopupAsync<CsharpBindingPopupViewModel>(Application.Current!.Windows[0].Page!.Navigation, new PopupOptions(), token); |
There was a problem hiding this comment.
Using ! is not ideal. Can you possibly do a null check and return a InvalidOperationException or similar?
| onPresenting: viewModel => viewModel.PerformUpdates(10), | ||
| token); | ||
| return popupService.ShowPopupAsync<UpdatingPopupViewModel>(Application.Current!.Windows[0].Page!.Navigation, new PopupOptions(), token); | ||
| } |
There was a problem hiding this comment.
Same as above. Using ! is not idea. A null check and/or throwing an exception if the app window is null would be my advice. It should never be in an invalid state when app is running.
| [RelayCommand] | ||
| Task OnShowPopupContent(CancellationToken token) | ||
| { | ||
| return popupService.ShowPopupAsync<PopupContentViewModel>(Application.Current!.Windows[0].Page!.Navigation, new PopupOptions(), token); |
| public sealed partial class PopupContentViewModel : BaseViewModel | ||
| { | ||
| [ObservableProperty] | ||
| string message = ""; |
There was a problem hiding this comment.
Any reason we are not using string.empty?
| { | ||
| popupService.ShowPopup<UpdatingPopupViewModel>(onPresenting: viewModel => viewModel.PerformUpdates(updates + 2)); | ||
| await popupService.ShowPopupAsync<UpdatingPopupViewModel>(Application.Current!.Windows[0].Page!.Navigation, new PopupOptions(), CancellationToken.None); |
There was a problem hiding this comment.
Same as above with ! not being recommended.
There was a problem hiding this comment.
Looks very well done! I am excited to see this merged. I was unable to test as there are merge conflicts. But once those are resolved I will test it. At this time I see no reason not to merge as soon as it can be tested. I would prefer not to use null forgiveness with grabbing the window object but I will let you decide if you want to do that. I will approve this as soon as i can test and verify it is functional.
|
Thanks @ne0rrmatrix, you can switch to a branch and run the app. The PR for now is to confirm the approach and API changes. We'll need a PR to mark the current popup as obsolete, and release MCT, and after that, I'll resolve merge conflicts and add docs. |
|
I created a branch and tested all of the features in Mulitple Popup page. There arre some issues with Multiple popup page just errors out on windows with invalid container. That issue is also a bug that is present for me in main with current popup. Could be user error? Not sure. I don't use popup much. On Updating popup page clicking more and then clicking finish reset the original item to go again. Was that intended? The Handle return result popup does not work as expected on IOS. It displays popup but does not show any response after closing. Neither touching outside popup or clicking on button initiates any visible response. On PopupAnchorPage I have unexpected behavior. I can move the red X exactly once before having to leave page and return to move or click on popup again. The button in popup responds but does nothing. On custom popup size and position the horizontal nd vertical options don't appear to do anything for me. Setting width and height does work 100 percent. When leaving the page attempting to return to same page in windows fails to navigate to page. This issue is not a popup issue. Just mentioning it for reference in case anyone wants it fixed. It is an issue with other things like media element page to give an example. This is an amazing start. I am pretty sure all of the issues I listed are compiled binding issues that are easy to fix and are the bane of anyone working with dotnet 9.x |
Description of Change
This is primarily aimed at playing around but also with the aim of exposing the implementation to see what everything thinks.
The popupcontainer is an internal ContentPage that is used to display content. there are 2 ways user can create popup. It can be a simple view or for more complex tasks user has to inherit from Popup. What are the complex tasks? In case you want to Close popup from the control or you want to get the result from the popup or you want to subscribe on OnOpened/OnClosed.
For MVVM users there is a PopupService. Pay attention all popups must be registered. Also you can close popup from PopupService only if you opened it using PopupService. DO NOT combine extension method and PopupService.
Now all configurations live in PopupOptions. You can configure BackgroundColor (Dim), popup size and popup layout position. Dissmiss by outside tap also exist in PopupOptions.
The BindingContext is set automatically to PopupContainer, Popup and View.
As the new Popup uses only MAUI Controls, we expect you get all benefits of HotReload. All Controls including Popup in Popup and MediaElement should work without issues.
Features currently removed: AnchorView.
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information