Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed possible NRE on MarkdownTextBlock. #586

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Fixed possible NRE on MarkdownTextBlock. #586

merged 3 commits into from
Nov 13, 2024

Conversation

azchohfi
Copy link
Contributor

@azchohfi azchohfi commented Nov 6, 2024 •
edited by Arlodotexe
Loading

Fixes #585.

Arlodotexe
Arlodotexe approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@Arlodotexe Arlodotexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Seems like a simple case we should have had tests for already, should be straightforward to add them while we're here.

@azchohfi
Copy link
Contributor Author

I'll add a new test. It seems like this didn't get exercised since Config was null.

@Arlodotexe Arlodotexe enabled auto-merge November 13, 2024 20:15
@Arlodotexe Arlodotexe merged commit ba694e0 into main Nov 13, 2024
20 of 21 checks passed
@michael-hawker michael-hawker mentioned this pull request Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arlodotexe Arlodotexe Arlodotexe approved these changes

Assignees

@Arlodotexe Arlodotexe

Labels
None yet
Projects
Toolkit 8.x
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Markdig-based MarkdownTextBlock crashes if no text is provided.
2 participants
@azchohfi @Arlodotexe