Extract Tpay Single Channel Pay-by-link as a separate payment method #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As we introduce a new payment method gateway, this seems as a BC break to me. A predefined Tpay channel ID configured for tpay_pbl will not work anymore. We need an upgrade file or something similar that will guide on how to use tpay_pbl_channel. |
coldic3
reviewed
Jan 20, 2025
There was a problem hiding this comment.
And we can remove support for defaultTpayChannelId form templates/shop/payment/_payByLink.html.twig. Or we can keep it with a comment, depending on how we want to handle a BC break.
lchrusciel
approved these changes
Jan 23, 2025
coldic3
reviewed
Jan 26, 2025
| 'help' => 'commerce_weavers_sylius_tpay.admin.gateway_configuration.tpay_channel_id_help', | ||
| 'required' => false, | ||
| 'attr' => [ | ||
| 'placeholder' => $this->translator->trans('commerce_weavers_sylius_tpay.admin.gateway_configuration.tpay_display_all_channels', domain: 'messages'), |
There was a problem hiding this comment.
This translation might be removed from the translation file.
| @@ -1,5 +1,5 @@ | |||
| {% set payment = order.lastCartPayment() %} | |||
|
|
|||
| {% if payment is not null and payment.method.gatewayConfig.gatewayName == 'tpay_pbl' %} | |||
| {% if payment is not null and payment.method.gatewayConfig.gatewayName == 'tpay_pbl'%} | |||
There was a problem hiding this comment.
-{% if payment is not null and payment.method.gatewayConfig.gatewayName == 'tpay_pbl'%}
+{% if payment is not null and payment.method.gatewayConfig.gatewayName == 'tpay_pbl' %}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #221