Code coverage #106
Draft
Code coverage #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arti0090
commented
Oct 24, 2024
| use PHPUnit\Framework\TestCase; | ||
| use Prophecy\PhpUnit\ProphecyTrait; | ||
|
|
||
| final class TrustedCertificateResolverTest extends TestCase |
There was a problem hiding this comment.
Do we even test this class?
If yes - is this correct and how to test RuntimeException of this class
If no - should I add this into phpunit.xml exclusions
|
|
||
| public function test_it_resolved_indexed_tpay_transaction_channels(): void | ||
| { | ||
| $this->markTestSkipped('Issue with GetTpayTransactionsChannels'); |
There was a problem hiding this comment.
I cannot make it to work as this GetTpayTransactionsChannels throws:
Typed property GetTpayTransactionsChannels::$result must not be accessed before initialization
arti0090
commented
Oct 24, 2024
| @@ -53,10 +53,6 @@ private function getInputClassFrom(array $context): ?string | |||
|
|
|||
| private function getConstructorArgumentName(string $inputClass): string | |||
| { | |||
| if (!is_a($inputClass, $this->getSupportedInterface(), true)) { | |||
There was a problem hiding this comment.
This might not be even required as the function supports checks this upfront
arti0090
commented
Oct 24, 2024
| <directory>src/Test</directory> | ||
| <directory>src/Twig</directory> | ||
|
|
||
| <!-- other files --> |
There was a problem hiding this comment.
Is it ok to exclude those files?
arti0090
commented
Oct 24, 2024
| @@ -41,5 +41,37 @@ | |||
|
|
|||
| <extensions> | |||
| <extension class="Symfony\Component\Panther\ServerExtension" /> | |||
There was a problem hiding this comment.
Suggested change
| <extension class="Symfony\Component\Panther\ServerExtension" /> | |
| <bootstrap class="Symfony\Component\Panther\ServerExtension" /> |
This can be changed from 10.5 phpunit - it will not throw that in this part XML is not valid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#96
Current state of coverage
usefull command:
XDEBUG_MODE=coverage vendor/bin/phpunit --coverage-html=coverage/ -d --min-coverage=90 tests/Unit/