Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: remove deprecated linter VSCode settings #159

Merged
merged 1 commit into from
Aug 7, 2023
Merged

MAINT: remove deprecated linter VSCode settings #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,6 @@
"python.analysis.autoImportCompletions": false,
"python.analysis.inlayHints.pytestParameters": true,
"python.analysis.typeCheckingMode": "strict",
"python.formatting.provider": "black",
"python.linting.banditEnabled": false,
"python.linting.enabled": true,
"python.linting.flake8Enabled": false,
"python.linting.mypyEnabled": false,
"python.linting.pydocstyleEnabled": false,
"python.linting.pylamaEnabled": false,
"python.linting.pylintEnabled": false,
"python.testing.pytestArgs": ["--color=no", "--no-cov", "-vv"],
"python.testing.pytestEnabled": true,
"python.testing.unittestEnabled": false,
Expand Down
4 changes: 0 additions & 4 deletions src/repoma/check_dev_files/deprecated.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
from repoma.utilities.vscode import (
remove_extension_recommendation,
remove_settings,
set_setting,
)

if TYPE_CHECKING:
Expand All @@ -39,7 +38,6 @@ def _remove_flake8() -> None:
executor(remove_precommit_hook, "flake8")
executor(remove_precommit_hook, "nbqa-flake8")
executor(remove_settings, ["flake8.importStrategy"])
executor(set_setting, {"python.linting.flake8Enabled": False})
executor.finalize()


Expand Down Expand Up @@ -91,7 +89,6 @@ def _remove_pydocstyle() -> None:
)
executor(__uninstall, "pydocstyle", check_options=["lint", "sty"])
executor(remove_precommit_hook, "pydocstyle")
executor(set_setting, {"python.linting.pydocstyleEnabled": False})
executor.finalize()


Expand All @@ -103,7 +100,6 @@ def _remove_pylint() -> None:
executor(remove_precommit_hook, "pylint")
executor(remove_precommit_hook, "nbqa-pylint")
executor(remove_settings, ["pylint.importStrategy"])
executor(set_setting, {"python.linting.pylintEnabled": False})
executor.finalize()


Expand Down
1 change: 0 additions & 1 deletion src/repoma/check_dev_files/mypy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ def _update_vscode_settings() -> None:
settings = {
"mypy-type-checker.args": ["--config-file", "pyproject.toml"],
"mypy-type-checker.importStrategy": "fromEnvironment",
"python.linting.mypyEnabled": False,
}
executor(set_setting, settings)
executor.finalize()
Expand Down
8 changes: 8 additions & 0 deletions src/repoma/check_dev_files/vscode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,14 @@ def _remove_outdated_settings() -> None:
"githubPullRequests.telemetry.enabled",
"gitlens.advanced.telemetry.enabled",
"python.analysis.diagnosticMode",
"python.formatting.provider",
"python.linting.banditEnabled",
"python.linting.enabled",
"python.linting.flake8Enabled",
"python.linting.mypyEnabled",
"python.linting.pydocstyleEnabled",
"python.linting.pylamaEnabled",
"python.linting.pylintEnabled",
"telemetry.telemetryLevel",
]
vscode.remove_settings(outdated_settings)
Expand Down
Loading