Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX: Add Sphinx Comments: Hypothesis #38

Merged
merged 5 commits into from
Jun 26, 2024
Merged

DX: Add Sphinx Comments: Hypothesis #38

merged 5 commits into from
Jun 26, 2024

Conversation

shenvitor
Copy link
Member

@shenvitor shenvitor commented Jun 26, 2024

Closes #37
Also, fix minor format issue in reaction.md

@shenvitor shenvitor added the 🖱️ DX Improvements to the Developer Experience label Jun 26, 2024
@shenvitor shenvitor requested a review from redeboer June 26, 2024 11:04
@shenvitor shenvitor self-assigned this Jun 26, 2024
docs/conf.py Outdated Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved
docs/reaction.md Outdated Show resolved Hide resolved
@shenvitor shenvitor changed the title DX: Add Sphinx Comments: Hypothesis, Dokieli, Utterances DX: Add Sphinx Comments: Hypothesis, Dokieli Jun 26, 2024
docs/conf.py Outdated Show resolved Hide resolved
Copy link
Member

@redeboer redeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks, LGTM 🥇

@shenvitor shenvitor changed the title DX: Add Sphinx Comments: Hypothesis, Dokieli DX: Add Sphinx Comments: Hypothesis Jun 26, 2024
@shenvitor shenvitor merged commit ceacbde into main Jun 26, 2024
4 checks passed
@shenvitor shenvitor deleted the sphinx-comments branch June 26, 2024 12:12
@shenvitor
Copy link
Member Author

@redeboer man... just noticed that Utterances is actually enabled in compwa.github.io
:)
see https://github.com/ComPWA/compwa.github.io/blob/965b794543738d256ff59261a36fe26b2062235e/docs/conf.py#L101C1-L102C1

@redeboer
Copy link
Member

Yes it is, as a test. But as you can see, it doesn't work well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖱️ DX Improvements to the Developer Experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install sphinx-comments and activate Hypothesis
2 participants