Shift remap fix #169
Open
Shift remap fix #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See issue ColinPitrat#167 for discussion. When the shift state is different for a key press and release event and where keys are remapped to different physical CPC keys, the emulator can receive key up/downs on different keys which results in 'stuck', repeating keys. This fix tracks the shift states of physical PC keys to ensure the correct keys are pressed/released on the emulator.
InputMapper::CPCkeyFromKeysym functionality is changed by 0ee0d87 so add shift state in function calls.
|
Sorry I've not been looking into this for a very long time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, here's the revised version discussed in #167 for your perusal. I've tested it with a couple of games and with Protext and CP/M. I've updated the keymapping tests.