Feat: 게시글 공동저자 설정 / 공개 범위 설정 / 소속 팀 설정 API 기능 구현 #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
yumzen
reviewed
Jan 5, 2025
| @PatchMapping("/coauthor/{postId}") | ||
| @Operation(summary = "게시글 공동 저자 설정 API", description = "게시글의 공동 저자를 설정합니다.") | ||
| public ApiResponse<PostResponseDTO.UpdatePostResultDTO> setPostCoauthor(@PathVariable Long postId, @RequestBody PostRequestDTO.UpdateCoauthorRequestDTO request) { | ||
| Member member = memberCommandService.getRequester(); |
There was a problem hiding this comment.
멤버정보는 @AuthenticationPrincipal CustomMemberDetails customMemberDetails 사용하면 될 것 같습니다!
| // 새로운 공동 저자 리스트 추가 | ||
| Set<Author> coauthors = request.getMemberIds().stream() | ||
| .map(newCoauthorId -> { | ||
| Member newCoauthor = memberRepository.findById(newCoauthorId).orElseThrow(() -> new IllegalArgumentException("Member not found: " + newCoauthorId)); |
There was a problem hiding this comment.
예외처리 GeneralException 사용 안하신 이유가 있나요?
| public Post setPostTeam(Long postId, Long teamId) { | ||
| Post post = postRepository.findById(postId).orElseThrow(() -> new GeneralException(ErrorStatus.POST_NOT_FOUND)); | ||
|
|
||
| Member authenticatedMember = getAuthenticatedMember(); |
There was a problem hiding this comment.
getAuthenticatedMember를 만드신 이유가 궁금합니다!
There was a problem hiding this comment.
현재 로그인한 사용자가 게시글을 작성한 저자와 일치하는지 확인하기 위해 썼습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
🔎코드 설명 및 참고 사항
💬리뷰 요구사항