Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: 게시물 댓글 CRUD 구현 #257

Merged
merged 13 commits into from
Nov 10, 2024
Merged

Feat: 게시물 댓글 CRUD 구현 #257

merged 13 commits into from
Nov 10, 2024

Conversation

lee-haeseung
Copy link
Member

#️⃣연관된 이슈

📝작업 내용

댓글 관련 코드 구현

🔎코드 설명 및 참고 사항

💬리뷰 요구사항

@lee-haeseung lee-haeseung added the ✨ Feature 기능 개발 label Nov 1, 2024
@lee-haeseung lee-haeseung self-assigned this Nov 1, 2024
@lee-haeseung lee-haeseung linked an issue Nov 1, 2024 that may be closed by this pull request
Feat: 댓글 관련 API 개발 #256
Closed
yumzen
yumzen reviewed Nov 2, 2024
View reviewed changes
Copy link
Member

@yumzen yumzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

댓글 조회부분 피그마 디자인에는 페이지네이션이 없는 것 같은데 페이지네이션 기능을 추가하신 이유가 있나요?

@lee-haeseung
Copy link
Member Author

댓글 조회부분 피그마 디자인에는 페이지네이션이 없는 것 같은데 페이지네이션 기능을 추가하신 이유가 있나요?

맞네요...! 당연히 있겠지하고 만들었는데 관련 코드 주석처리하고 페이지네이션 삭제하도록 하겠습니다!

@lee-haeseung lee-haeseung requested a review from yumzen November 6, 2024 17:26
lee-haeseung and others added 3 commits November 8, 2024 03:37
@lee-haeseung
Merge branch 'develop' of https://github.com/Codiary-UMC-6th/Backend-…
0e0d04d 
…Codiary into feature/#256-comment
@lee-haeseung
Fix: uuid 경로 수정
d3c5766
@lee-haeseung
Merge branch 'develop' of https://github.com/Codiary-UMC-6th/Backend-…
6d9fd9c 
…Codiary into feature/#256-comment

# Conflicts:
#	src/main/java/com/codiary/backend/domain/post/service/PostCommandService.java
@lee-haeseung lee-haeseung merged commit 0c4c740 into develop Nov 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ParkJh38 ParkJh38 Awaiting requested review from ParkJh38

@yumzen yumzen Awaiting requested review from yumzen

Assignees

@lee-haeseung lee-haeseung

Labels
✨ Feature 기능 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: 댓글 관련 API 개발
2 participants
@lee-haeseung @yumzen