Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ToolTip single word wrap #3019

Open
wants to merge 6 commits into
base: cass-gm-915-945
Choose a base branch
from
Open

fix: ToolTip single word wrap #3019

wants to merge 6 commits into from
+31 −10

Conversation

dreamwasp
Copy link
Contributor

@dreamwasp dreamwasp commented Jan 29, 2025 •
edited
Loading

Overview

Fixes long single words from overflowing their container in ToolTips

This ended up being very quick, so I am lumping these changes in with the other ToolTip fixes this is branched off of

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [gm-914]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  1. Head to ToolTips
  2. See inline tooltips with long words no longer overflow their container
  3. Head to PreviewTips
  4. See inline line PreviewTips with long words no longer overflow their container

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 29, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 80b4ae8.

☁️ Nx Cloud last updated this comment at 2025-01-30 19:51:20 UTC

@dreamwasp dreamwasp marked this pull request as ready for review January 29, 2025 21:43
@dreamwasp dreamwasp requested a review from a team as a code owner January 29, 2025 21:43
@dreamwasp dreamwasp requested review from timjenkins, BandanaKM, LinKCoding and aresnik11 and removed request for a team January 29, 2025 21:43
LinKCoding
LinKCoding reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@LinKCoding LinKCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

For Tooltip, it looks like the "Wondereeeeee..." shifts the tooltip over to the left, does it need a width? or max-width?

Infotip looks good tho!

@dreamwasp
Copy link
Contributor Author

image

For Tooltip, it looks like the "Wondereeeeee..." shifts the tooltip over to the left, does it need a width? or max-width?

Infotip looks good tho!

ooo, this is a floating bug 😮‍💨 i'll fix!

@LinKCoding LinKCoding self-requested a review January 30, 2025 19:39
LinKCoding
LinKCoding approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@LinKCoding LinKCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://679bd84e9905642e65a96cdf--gamut-preview.netlify.app

Deploy Logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinKCoding LinKCoding LinKCoding approved these changes

@timjenkins timjenkins Awaiting requested review from timjenkins timjenkins is a code owner automatically assigned from Codecademy/gamut

@BandanaKM BandanaKM Awaiting requested review from BandanaKM BandanaKM is a code owner automatically assigned from Codecademy/gamut

@aresnik11 aresnik11 Awaiting requested review from aresnik11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dreamwasp @codecademydev @LinKCoding