Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lua: comments.md incorrectly shows comment close as ]]-- #5925

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Lua: comments.md incorrectly shows comment close as ]]-- #5925

wants to merge 5 commits into from

Conversation

angusjf
Copy link

@angusjf angusjf commented Jan 9, 2025

Description

This is wrong, as in the case

print(--[[ I am a comment ]]-- 123)

The way to close a multiline comment is to close the string with `]]

print(--[[ I am a comment ]] 123)

Issue Solved

No issue solved

Type of Change

  • Editing an existing entry (fixing a typo)

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@angusjf
Lua: comments.md incorrectly shows comment close as ]]--
c13e157 
This is wrong, as in the case
```lua
print(--[[ I am a comment ]]-- 123)
```
The way to close a multiline comment is to close the string with `]]

```lua
print(--[[ I am a comment ]] 123)
```
@PragatiVerma18 PragatiVerma18 self-assigned this Jan 10, 2025
PragatiVerma18
PragatiVerma18 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @angusjf, thanks for contributing to docs, your PR is good for a second review! 🚀

@angusjf
Copy link
Author

angusjf commented Jan 10, 2025

@PragatiVerma18 thank you :)))

@avdhoottt avdhoottt self-assigned this Jan 10, 2025
@avdhoottt avdhoottt added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PragatiVerma18 PragatiVerma18 PragatiVerma18 approved these changes

Assignees

@PragatiVerma18 PragatiVerma18

@avdhoottt avdhoottt

Labels
new entry New entry or entries status: review 1️⃣ completed status: under review Issue or PR is currently being reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@angusjf @PragatiVerma18 @avdhoottt