Add implementation of interfaces project #131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-systems ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestInitialBytesAreRead(t *testing.T) { |
There was a problem hiding this comment.
could be done as a table driven test, which is better go idiom imo
There was a problem hiding this comment.
Could I bother you to sketch out what the per-testcase struct would look like here?
I put together my best guess in buffer_table_test.go, but it feels like quite a bit of added complexity, and like it makes the tests harder to read and interpret. Maybe I'm just not looking at it the right way, and that's not what you had in mind?
Also switch FilteringPipe tests to be table-driven.
illicitonion
force-pushed
the
impl/interfaces
branch
from
cc9349f
to
64cf92e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample answer for the interfaces project in #130