-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update index Prep DB/SQL S4 PD.md #511
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-curriculum ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kfklein15
requested review from
40thieves,
illicitonion,
SallyMcGrath and
LaraHuzjan
January 9, 2024 10:04
SallyMcGrath
requested changes
Jan 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of requests here:
- Looks like a copypasta victim on the last tab, a letter missing from To making o
- Please do not name links in this way. Links must make sense out of context. There's no way to tell the difference between this article and this article (the text of your two links). I made a ticket on your board about this recently. It's a common problem in our curriculum.
I have amended it on the CMS. Thanks for spotting these, @SallyMcGrath |
SallyMcGrath
approved these changes
Jan 11, 2024
sztupy
added a commit
to sztupy/curriculum
that referenced
this pull request
Jan 25, 2024
…tion * origin/main: (26 commits) fix objective indexing restore js3 prep workshops making site run again now modules are being consumed correctly (CodeYourFuture#541) Feature: replace labs again (CodeYourFuture#540) Update: move netlify tooling (CodeYourFuture#539) feature; stage 2: mounting this repo as modules (CodeYourFuture#538) Feature: stage 1: port labs (CodeYourFuture#537) Feature: Daniel's tooling for local module replacements (CodeYourFuture#535) Update style of the hamburger menu (CodeYourFuture#478) (CodeYourFuture#528) Update content/en/js3/success/index.md Update content/en/js3/success/index.md add step->prep workshops for JS2 & JS3 Add minutes archetypes for all required module views (CodeYourFuture#529) add major change warning (CodeYourFuture#527) parametrize createFilmCard with template (CodeYourFuture#524) link to the module js3 project reference the module js3 project success criteria in the js3 module success page Update index adding PD success.md (CodeYourFuture#518) Update index Prep DB/SQL S4 PD.md (CodeYourFuture#511) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Module: DB/SQL
Week(s): 4
Checklist
Description
Who needs to know about this?