Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index Prep DB/SQL S4 PD.md #511

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Update index Prep DB/SQL S4 PD.md #511

merged 1 commit into from
Jan 11, 2024

Conversation

kfklein15
Copy link
Contributor

What does this change?

Module: DB/SQL
Week(s): 4

Checklist

Description

Who needs to know about this?

Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for cyf-curriculum ready!

Name Link
🔨 Latest commit ea0cb82
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/659d19c9b9be010008ce3ae7
😎 Deploy Preview https://deploy-preview-511--cyf-curriculum.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 91 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of requests here:

  1. Looks like a copypasta victim on the last tab, a letter missing from To making o
  2. Please do not name links in this way. Links must make sense out of context. There's no way to tell the difference between this article and this article (the text of your two links). I made a ticket on your board about this recently. It's a common problem in our curriculum.

CodeYourFuture/CYF-PD#43

@kfklein15
Copy link
Contributor Author

I have amended it on the CMS. Thanks for spotting these, @SallyMcGrath

@SallyMcGrath SallyMcGrath merged commit 8c7967f into main Jan 11, 2024
4 checks passed
@SallyMcGrath SallyMcGrath deleted the kfklein15-patch-1 branch January 11, 2024 00:52
sztupy added a commit to sztupy/curriculum that referenced this pull request Jan 25, 2024
…tion

* origin/main: (26 commits)
  fix objective indexing
  restore js3 prep workshops
  making site run again now modules are being consumed correctly (CodeYourFuture#541)
  Feature: replace labs again (CodeYourFuture#540)
  Update: move netlify tooling (CodeYourFuture#539)
  feature; stage 2: mounting this repo as modules (CodeYourFuture#538)
  Feature: stage 1: port labs  (CodeYourFuture#537)
  Feature: Daniel's tooling for local module replacements (CodeYourFuture#535)
  Update style of the hamburger menu (CodeYourFuture#478) (CodeYourFuture#528)
  Update content/en/js3/success/index.md
  Update content/en/js3/success/index.md
  add step->prep workshops for JS2 & JS3
  Add minutes
  archetypes for all required module views (CodeYourFuture#529)
  add major change warning (CodeYourFuture#527)
  parametrize createFilmCard with template (CodeYourFuture#524)
  link to the module js3 project
  reference the module js3 project success criteria in the js3 module success page
  Update index adding PD success.md (CodeYourFuture#518)
  Update index Prep DB/SQL S4 PD.md (CodeYourFuture#511)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants