Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase supported django version to < 5 #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tiholic
Copy link
Contributor

@tiholic tiholic commented Mar 22, 2022

Increase django supported version from < 4 to < 5

Note: prefer squash and merge on this PR please :)

fix deprecation warning for `ugettext_lazy` and update django supported version
@chris-umed
Copy link

@sjamaan @ashishnitinpatil @emanuelmd @mkay849 - will this be merged soon? It is now a blocker for our project and would prefer not to have to fork your project just for this.

@ashishnitinpatil
Copy link
Contributor

This should ideally be tested for django version 4. The project has a tox.ini which should be updated along with the requirements change and well, tested. I do not maintain the library so have no permissions to merge or release.

@sjamaan
Copy link
Contributor

sjamaan commented Aug 11, 2022

This should ideally be tested for django version 4. The project has a tox.ini which should be updated along with the requirements change and well, tested. I do not maintain the library so have no permissions to merge or release.

Unfortunately, I don't work with Django anymore at the moment and I won't have the time to maintain this library. Perhaps @abzainuddin can have a look - the change LGTM at least, although the gettext suppression seems to have disappeared? I'd suggest at least changing the commit message before merging.

@uhurusurfa
Copy link

uhurusurfa commented Aug 11, 2022

Given Django 2 is no longer officially supported and it creates complications to support v2 and v4, Django 2 should no longer be supported and users stil on Django 2 can download the current released version.
A PR will be raised shortly that implements github actions to run the tox tests and supports Django 4 by @martin-marty

@sevdog sevdog mentioned this pull request Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants