-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass intercom app id in environment for Grunt build #1685
Open
tosih
wants to merge
777
commits into
master
Choose a base branch
from
add_intercom_app_id_as_env
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
777 commits
Select commit
Hold shift + click to select a range
c281627
Merge remote-tracking branch 'origin/master' into add-milestone-2-new…
08493ce
Merge remote-tracking branch 'origin/master' into add-milestone-2-new…
f59cf53
Added reset eutton and proper toggling of popovers
78c4d7c
Changed copy
2b3e07c
Only check for non build failures
d268047
Merge pull request #1740 from CodeNow/SAN-5016-closing-sidebar
Myztiq 3c0f9c2
4.21.8
f8fc641
Updated logic for showing the sidebar popover to be more specific to …
2c9485d
Hide the sidebar toggle when not in the guide.
1f45707
Fixed terminal page disabling
a438fc8
isPopoverOpen() -> shouldShowPopover
242bcc7
Fixing stupid mistake.
1d864de
Casing
bf464d9
Fixed logic so we are in the right stages at the right moments.
a6f64a5
Fixed failing tests...
37e5da9
Merge pull request #1754 from CodeNow/SAN-5000-replace-configuration-…
Myztiq f82f22a
Merge pull request #1751 from CodeNow/analytics-modify_click_tracking
Myztiq 01fa4cc
Merge pull request #1755 from CodeNow/SAN-5036-popover-display-logic
Myztiq c206e6a
Merge pull request #1759 from CodeNow/SAN-5072-auto-launch-aha
Myztiq 67619e8
4.21.9
456fe8f
Merge pull request #1757 from CodeNow/SAN-5052-disable-terminal
Myztiq 3d9c26b
Merge remote-tracking branch 'origin/master' into SAN-4999-remove-bin…
00e05d2
Merge remote-tracking branch 'origin/master' into add-milestone-2-new…
c91e385
Merge pull request #1756 from CodeNow/SAN-5071-hide-toggle-sidebar
Myztiq e3d8b83
4.21.10
6180b74
Merge pull request #1672 from CodeNow/add-wordpress-icon
runnabro fcc84ce
Merge pull request #1733 from CodeNow/SAN-4999-remove-bind-to-all-int…
henrymollman 8a8c452
4.21.11
ffe7e4e
Merge pull request #1735 from CodeNow/enable-config-terminal
Myztiq 8970ae2
4.22.0
292f37d
Merge pull request #1736 from CodeNow/enable-web-toolbar
Myztiq d652f9e
4.23.0
575f9a6
Merge pull request #1753 from CodeNow/aha-guide-url-tooltip
Myztiq 2576d9c
4.23.1
5304289
Merge remote-tracking branch 'origin/master' into SAN-4982-adding-bra…
0141129
instances.models
ff15c93
Cleaned up unused code and making sure popovers only appear for 1 non…
f88d33a
Merge remote-tracking branch 'origin' into add-milestone-2-new-popover
058cea9
Redirect when aha guide is unfinished
db75d6a
Fixing popover actions for static popover
2914b66
send configurationMethod to createNewBuildService and set the propert…
Nathan219 bc33a87
JSHint fix
dfe071f
Merge pull request #1761 from CodeNow/SAN-5043-redirect-unfinished-aha
Nathan219 1a2106f
Merge pull request #1763 from CodeNow/SAN-5024-blank-dockerfile
Nathan219 578e556
4.23.2
Nathan219 a1723c0
Merge pull request #1737 from CodeNow/SAN-4982-adding-branch-doesnt-i…
Myztiq 9b4c65d
Merge remote-tracking branch 'origin/master'
Nathan219 e339152
Merge remote-tracking branch 'origin/master' into SAN-5033-autolaunch…
Nathan219 d467419
use isSettingUpAutoLaunch in most places where isSettingUpRunnabot sh…
Nathan219 4970fa3
Merge pull request #1734 from CodeNow/enable-blank-dockerfile-ff
Nathan219 45cd819
4.23.3
Nathan219 a858553
turn on GI
Nathan219 0677b0e
Merge pull request #1764 from CodeNow/enable-pr-bot
Nathan219 4eaf9e5
4.23.4
Nathan219 3c12731
add contingency plan
taylordolan f48612a
hang tight -> bear with us
taylordolan b3fba9c
Merge branch 'master' of https://github.com/CodeNow/runnable-angular …
taylordolan 20f744f
add ahaService external call when GithubIntegration controller finds …
Nathan219 dae64cf
Reduce unnecessary calls
6639579
Merge pull request #1744 from CodeNow/SAN-5033-autolaunch-shown-too-e…
Nathan219 71826e9
4.23.5
Nathan219 f48ea34
Added jsdoc, removed hyphen case and unneeded listener
c589122
update copy
taylordolan 22281f4
being dumb
Nathan219 9120e86
Merge pull request #1766 from CodeNow/fix-rapid-github-check
thejsj 05ca63c
4.23.6
thejsj 850d4d9
link to docs for "chat with our devs"
taylordolan c32cd20
Merge remote-tracking branch 'origin/master' into add-milestone-2-new…
155603c
fix "ask our engineers"
taylordolan 2ad1fa9
more copy updates
taylordolan c0bd13f
Edited aha guide controller to not care about non repo instance
148b8a7
fix popover for auto-launch
Nathan219 359c0fa
Merge pull request #1762 from CodeNow/add-milestone-2-new-popover
henrymollman 3688fc3
Flag set to true
87f955e
merge master
taylordolan 48b501d
4.23.7
7f366d7
Merge pull request #1767 from CodeNow/copy-updates
runnabro 1b0b0b7
4.23.8
1c25a53
fix copy
taylordolan 1d035c3
merge master
runnabro a3b2db9
Merge branch 'add-contingency-plan' of github.com:CodeNow/runnable-an…
thejsj 72b6dd9
First commit for feature
931d2a9
Merge remote-tracking branch 'origin/master' into milestone-2-tracking
b50b6c7
Add email to contigency plan
thejsj bddbb32
Merge branch 'add-contingency-plan' of github.com:CodeNow/runnable-an…
thejsj b7af5b3
Add checkers in EC and CIS to check if the Aha sidebar should be shown
Nathan219 f2f440a
Merge pull request #1765 from CodeNow/add-contingency-plan
taylordolan 20ddbd5
watch for org changes
Nathan219 f632e4e
Store last step for use
73169de
Merge pull request #1768 from CodeNow/fixes-for-aha
Nathan219 17ec79e
4.23.9
Nathan219 a98bfb6
Merge pull request #1770 from CodeNow/Aha-show-sidebar-on-instance-re…
Nathan219 3b0f278
Merge pull request #1771 from CodeNow/ASAP-join-room-on-org-switch
Nathan219 2dc6274
4.23.10
Nathan219 1aca773
Merge remote-tracking branch 'origin' into milestone-2-tracking
b7aa7d5
Merge remote-tracking branch 'origin/master' into milestone-2-tracking
Nathan219 2cb8d61
Fixed broken aha end triggering
3777119
Merge branch 'milestone-2-tracking' of github.com:CodeNow/runnable-an…
698970a
Close sidebar when ready
3777794
Fix tests
0317280
Merge pull request #1772 from CodeNow/milestone-2-tracking
Nathan219 baf379e
Merge pull request #1769 from CodeNow/aha-feature-flag
Nathan219 6f4a64a
5.0.0
Nathan219 9b4eb11
The add services popover will remain open if not dismissed before cli…
8dbbe7d
add shitty polling for now
Nathan219 e2c0934
add check to stop early
Nathan219 c47b5b3
Tests
Nathan219 12c0607
Merge pull request #1774 from CodeNow/ASAP-fix-build-logs
Nathan219 d0b99f0
5.0.1
Nathan219 4b3b5a5
oops
Nathan219 77b46a1
Merge pull request #1775 from CodeNow/asap-again
Nathan219 1af2585
5.0.2
Nathan219 c91e67a
Merge pull request #1773 from CodeNow/fix-services-popover
henrymollman 99d1b21
5.0.1
d91d025
Merge branch 'master' of github.com:CodeNow/runnable-angular
057544a
5.0.3
18f82d5
Changed X in aha sidebar to always show and close, removed unused tem…
9a80f47
Merge pull request #1776 from CodeNow/always-show-close-x
henrymollman bd0a5a2
5.0.4
c1b8ebd
Merge branch 'master' of github.com:CodeNow/runnable-angular
b2f4756
Update ahaGuideService.js
prafulrana 76a3001
more copy fixes
taylordolan 9a13724
remove period
taylordolan 0c4af10
Clicking `Create Template` now closes all popovers
debc174
remove the polling I added as a stop gap
Nathan219 0b0bfca
updated segment to purge dynamically created events
sundippatel 97cafd8
Merge pull request #1780 from CodeNow/update-segment
Nathan219 d008128
5.0.5
Nathan219 b2c0c72
Merge pull request #1778 from CodeNow/SAN-5098-close-guide-popover
Myztiq 9cf2ffd
Updated logic to determine if we should seutp runnabot based on the f…
f2d5c07
add mix panel event on org select
runnabro 4610beb
add aha popover for branch URL
taylordolan f8c077b
fix mix panel script
runnabro 3d8c77e
Changed auto launch to occur outside of aha guide logic, fixed sideba…
e08ba37
PR comments
ce55f52
clean up .popover-aha
taylordolan 7efe864
update runnabot text
taylordolan 595619d
Added new popover element for auto fork with individual logic
5f72eb1
track org select
runnabro d764d16
Merge pull request #1781 from CodeNow/SAN-5101-runnabot-setup-flag
Myztiq 8057452
Popover logic back in aha guide service
a03708a
broadcast called after response that guide is indeed ended
c0b11c3
Added semicolon
b04cf3d
update api-client to latest for the best fixes
Nathan219 c9f0925
fix text-overflow
taylordolan e6ef2b0
send event names to mix panel
runnabro 3ff6635
fix function
runnabro 27b97d8
replace icons in add buttons with text
taylordolan 0faba4a
prepend event-names with data-
runnabro fffa377
Merge pull request #1782 from CodeNow/add-mixpanel-events
runnabro 3a4947b
Merge pull request #1785 from CodeNow/remove-build-log-polling
Nathan219 8628836
5.0.6
Nathan219 36d4bed
Merge pull request #1777 from CodeNow/copy-changes-aha-guide
Nathan219 f663f0f
5.0.7
Nathan219 c88ff4b
Added tests for ahaguide and ahaservice
55368dc
responsiveness
taylordolan fd1dc4c
Used watch instead of watchCollection
327d38b
Fixed bug with edit header modal not displaying text after user progr…
da7e28b
Changed text appearing in aha guide when user is building with a blan…
85b51ab
split aha popover styles into their own files
taylordolan 088ef08
Fixed issue with duplicate errors on environment page after exited ea…
1a049f0
fix text color in active state
taylordolan 17c24cd
Edited watch
606b57f
Fixed bug that would show the wrong color for the error icon
ff1820c
Used includes rather than check each individual substep in ng-if
e5a4ddc
Merge pull request #1784 from CodeNow/branch-url-aha-step
runnabro c7db5ef
add titles for text-overflow
taylordolan 5c1d0b3
Merge branch 'master' of https://github.com/CodeNow/runnable-angular …
taylordolan c826df7
Changed css styles for setup confirmation modal to move modal 43 pixe…
c10c183
Removed unused rootscope dependency
249fd6c
Merge pull request #1783 from CodeNow/SAN-5101-auto-launch-fix
henrymollman 999a155
Possible funnel
5d99aa9
Merge branch 'master' of https://github.com/CodeNow/runnable-angular …
runnabro 9da7289
add segment tracking for selecting an org
runnabro 70a40e9
This adds a reset button for the aha guide. It will appear in the fea…
1382573
Fix spacing
c82ffcb
Merge pull request #1794 from CodeNow/add-aha-reset
henrymollman 8262cce
Merge pull request #1791 from CodeNow/SAN-5096-wrong-color
henrymollman 0883893
Merge pull request #1790 from CodeNow/SAN-5104-dupe-error-state
henrymollman 0a995fc
update repository icons
taylordolan 3a81358
5.0.8
2e10f1b
update button copy
runnabro 7436db5
remove unused styles
runnabro f8db48b
move override styles to override files
taylordolan 3457a66
Merge pull request #1796 from CodeNow/update-repository-icons
runnabro 5d849b7
Choose -> Select
taylordolan e1bbfe4
missed one
taylordolan 899590c
fix use of wrong class
taylordolan 489057c
Merge pull request #1792 from CodeNow/update-popover-menus
runnabro 2367617
add tracking when aha starts
runnabro 83a2fb9
Merge branch 'master' of https://github.com/CodeNow/runnable-angular …
runnabro 2c3c0cd
PR comments
6eadefc
Merge remote-tracking branch 'origin/master' into SAN-5107-wrong-conf…
11a39b7
Fixed missing ellipsis button in staticAddRepo modal
0a22b56
Merge pull request #1786 from CodeNow/aha-guide-tests
henrymollman 3692353
Merge pull request #1788 from CodeNow/SAN-5047-header-text-missing
henrymollman 3976f51
Merge pull request #1789 from CodeNow/SAN-5107-wrong-config-text
henrymollman 0d51328
5.0.9
4de1d3d
fix typo
taylordolan a555e7a
add milestone 2 tracking
runnabro 8ef8a6f
remove unused function
runnabro 308abe3
Segment: force page call. needed before track calls.
sundippatel 3935d16
shouldnt need this anymore
sundippatel 841622c
Just ignore it. It's useless
Nathan219 d9e76ac
Merge pull request #1798 from CodeNow/analytics-trigger-page-event
Nathan219 50c6309
Merge pull request #1799 from CodeNow/stop-displaying-collection-requ…
Nathan219 5133160
5.0.10
Nathan219 821e3f0
use pushed_at instead of updated_at
Nathan219 8f20e7c
do it in this one, too
Nathan219 9d232b8
Added deep checking for dockerfiles and accompanying tests. Added pol…
e3d25f8
PR comments, better solution, fixed all issues
d352385
remove $state
runnabro 70f1ff3
Merge pull request #1797 from CodeNow/aha-funnel-tests
runnabro 6656cc8
5.0.11
runnabro 675f19e
PR comments and added error tests
daf1cd0
Forgot to remove this
9072c51
add event for starting milestone 2
runnabro 337dd62
5.0.12
runnabro f15e449
Moved error handler to call in setupServerMirrorController
991724f
Added close function to error handling
1c93ca3
add event for building
runnabro eaa3552
5.0.13
runnabro 3b74288
fix milestone 2 started tracking
runnabro 4a89dcf
5.0.14
runnabro 2503aa2
Merge pull request #1801 from CodeNow/pimmr-error
henrymollman 684552b
add disabled styles for back arrow
runnabro eb96932
5.0.15
d3b9a2d
add 2 user min copy
runnabro 47929c4
Re added missing template and updated ahaguide service to exit that …
fc73764
Merge pull request #1800 from CodeNow/SAN-3846-repo-update-date-was-w…
runnabro 2a08cc8
Merge pull request #1803 from CodeNow/SAN-4758-3-user-min
taylordolan 826f038
actually add .disabled class
runnabro ba57101
Merge pull request #1802 from CodeNow/SAN-4959-disable-back-state
taylordolan 520d8a1
Removing bad substep name
6031516
Merge pull request #1612 from CodeNow/ASAP-fetch-files-before-deleting
Nathan219 5501818
Fixed getAllBranches to get more pages.
923c01c
Made call to fetch repo branches
8fa7691
Fixed tests
292f00c
Merge pull request #1807 from CodeNow/fix-pagination-on-branches-fetch
henrymollman 4c2ea74
Merge pull request #1804 from CodeNow/SAN-5027-no-branches
henrymollman 411ea0d
5.0.16
610a3d2
Merge branch 'master' of https://github.com/CodeNow/runnable-angular …
taylordolan cdadfaa
alphabetize properties
taylordolan 165157a
Merge pull request #1793 from CodeNow/SAN-5100-setup-confirmation-mod…
taylordolan c812b16
Pass intercom app id in environment for Grunt build instead of hardco…
f233ee0
Fix variable to camelCase.
ab56cb4
Source config from file as process.env is unavailable.
fa1ba91
remove logs
Nathan219 2638703
fix
Nathan219 f0b7cfa
fix layout to use locals
Nathan219 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
'use strict'; | ||
|
||
require('app') | ||
.value('intercomAppId', require('config/environment').intercomAppId); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure if this bit will work. Does it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldnt it be